bump x/clipboard to v0.8.0 for Wayland support, keep vendor patches - #52
Merged
Merged
Conversation
Follow-up to #51, which bumped x/clipboard to v0.8.0 for native Wayland support. That PR's `go mod tidy` was incomplete and it also re-vendored the module verbatim, dropping cy's local patch that makes Write return an error and adds ReadErr. This restores that patch on top of v0.8.0 and reverts pkg/clipboard to the error-propagating API. `go mod vendor` also clobbers two other hand-patched modules (go-vte colon sub-parameters, go-daemon error wrapping). All three patches now live in patches/ and are re-applied by a new `just vendor` recipe so future bumps don't silently lose them. v0.8.0 speaks the X11 wire protocol directly, so libx11-dev is no longer needed to build on Linux; drop it from the workflows. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Q72W2BVbNZTQaiLsURxbe6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #51 by @wilsonsk0, which bumped
golang.design/x/clipboardto v0.8.0 for native Wayland support. Their commit is carried as-is; this branch adds one follow-up commit on top.What was wrong in #51
go mod tidywas incomplete, so CI's format/tidy diff check failed on stale go.sum entries.x/clipboard(ReadErr, andWritereturning anerror).pkg/clipboardwas then rewritten against the upstream API, which swallows write errors and loses read errors.Changes
pkg/clipboard/module.goto the error-propagating version. Upstream's PNG normalization inWriteis kept.go mod vendoralso clobbers two other hand-patched vendored modules (go-vte colon sub-parameters for styled underlines, go-daemon lock-file error wrapping). All three patches now live inpatches/with a README, and a newjust vendorrecipe runsgo mod tidy && go mod vendor && git apply patches/*.patch. The roundtrip reproduces the tree exactly. CLAUDE.md documents this.libx11-devfrom the workflows: v0.8.0 speaks the X11 wire protocol in pure Go, so the dev package is no longer needed to build on Linux.Verification
generate, format, tidy, lint, build,
go test -race ./pkg/... ./cmd/..., and the docs build all pass locally.Note for Wayland users: v0.8.0 uses the native backend only on compositors that expose a data-control manager (wlroots, KWin, GNOME 49+) and falls back to XWayland otherwise, so behavior on older GNOME is unchanged.
馃 Generated with Claude Code
https://claude.ai/code/session_01Q72W2BVbNZTQaiLsURxbe6
Generated by Claude Code