CFE-4541: Added symlinks promise type#112

Merged

olehermanse merged 1 commit intocfengine:masterfrom

victormlg:symlinks

Jun 27, 2025

Contributor

victormlg commented Jun 20, 2025

No description provided.

victormlg requested a review from olehermanse

June 20, 2025 15:16

victormlg force-pushed the symlinks branch 2 times, most recently from fe9733c to f0fef0d Compare

June 20, 2025 15:17

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/example.cf Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/test.cf Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

victormlg force-pushed the symlinks branch 3 times, most recently from 077910a to 5e232be Compare

June 23, 2025 09:19

victormlg requested a review from olehermanse

June 23, 2025 09:20

victormlg changed the title ~~Ticket: CFE-4541: Added symlinks promise type~~ CFE-4541: Added symlinks promise type

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/README.md Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

victormlg force-pushed the symlinks branch from 5e232be to 43caf20 Compare

June 23, 2025 13:24

victormlg force-pushed the symlinks branch from 43caf20 to 6a965a8 Compare

June 23, 2025 14:01

olehermanse self-requested a review

June 24, 2025 15:08

olehermanse requested changes

View reviewed changes

Member

olehermanse left a comment

Your promise type needs an enable.cf same as the others; https://github.com/cfengine/modules/blob/master/promise-types/ansible/enable.cf

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

victormlg force-pushed the symlinks branch from 6a965a8 to 9751ca8 Compare

June 25, 2025 08:05

victormlg requested a review from olehermanse

June 25, 2025 08:05

victormlg force-pushed the symlinks branch from 9751ca8 to e87a15d Compare

June 25, 2025 08:21

olehermanse requested a review from larsewi

June 25, 2025 11:02

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

victormlg force-pushed the symlinks branch from d575a29 to fce8c7f Compare

June 25, 2025 12:11

larsewi reviewed

View reviewed changes

Contributor

larsewi left a comment

Some minor comments. Otherwise it looks great. Thanks 🚀

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved

promise-types/symlinks/test.cf Show resolved Hide resolved

victormlg force-pushed the symlinks branch from fce8c7f to 88e313d Compare

June 26, 2025 13:50

victormlg requested a review from larsewi

June 26, 2025 13:51

victormlg force-pushed the symlinks branch from 88e313d to 73b1d0c Compare

June 26, 2025 13:52

olehermanse reviewed

View reviewed changes

promise-types/symlinks/symlinks.py Outdated Show resolved Hide resolved


          Added symlinks promise type

3dc5aae

Ticket: CFE-4541
Signed-off-by: Victor Moene <victor.moene@northern.tech>

victormlg force-pushed the symlinks branch from 73b1d0c to 3dc5aae Compare

June 27, 2025 07:46

victormlg requested a review from olehermanse

June 27, 2025 07:47

olehermanse approved these changes

View reviewed changes

olehermanse merged commit ad97de8 into cfengine:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet