ENT-11784: dnf package module #3069
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
Member
Author
|
OOps, this one isnt' ready for review yet. |
nickanderson
force-pushed
the
ENT-11784/master
branch
from
e46d0a5 to
50f8306
Compare
nickanderson
force-pushed
the
ENT-11784/master
branch
3 times, most recently
from
e06d2b8 to
a9eb479
Compare
nickanderson
force-pushed
the
ENT-11784/master
branch
from
a9eb479 to
5126d4c
Compare
larsewi
requested changes
Feb 4, 2026
Contributor
larsewi
left a comment
larsewi
left a comment
There was a problem hiding this comment.
Please fix pyright issues and also format with black. Then I will continue review afterwards
| base.conf.assumeyes = DEFAULT_ASSUME_YES | ||
| if with_repos: | ||
| base.read_all_repos() | ||
| base.fill_sack(load_system_repo='auto') |
Contributor
There was a problem hiding this comment.
According to pyright, the load_system_repo argument expects a boolean value, not string.
Member
Author
|
OK @larsewi I think I am ready for another review and squash |
- Uses dnf python library for interfacing with dnf - Use rpm library for currently installed packages (it's faster than dnf and /bin/rpm) Ticket: ENT-11784 Changelog: Added dnf package module
nickanderson
force-pushed
the
ENT-11784/master
branch
from
195b9ce to
2bc246c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built with vibes ....
Ticket: ENT-11784