Skip to content

[design change] Five pinned CTA bars leave five different gaps under the button (12.2dp to 57.5dp) #195

Description

@cestercian

Third pass of the device-walked spacing audit. Measured on the artistant AVD (Pixel 6, 420 dpi = 2.625 px/dp). Method and raw screenshots: docs/design-qa/spacing.

What is wrong

Five screens pin a primary button to the bottom edge. All five leave a different gap under it.

Screen Gap under the CTA Screenshot
EPK wizard 12.2 dp f05-wizard.png
Artist profile (04) 15.2 dp c07-artist-profile.png
Data export (93) 24.0 dp p06-data-export.png
Request quote (05) 28.2 dp f02-request-quote.png
Confirm request (06) 57.5 dp f03-step2.png
Design 04 specifies 30

A 45 dp spread. The wizard's 12.2 dp is the one to look at first — the Continue button sits hard against the home-indicator zone. Confirm request's 57.5 dp is partly explained: it carries a caption line under the button, which the others do not.

Design 04 is explicit about the shape of a dock:

<div style="padding:14px 20px 30px; display:flex; align-items:center; gap:12px">

14 top, 20 sides, 30 bottom. Only Request quote comes close.

Relationship to existing issues

Fix direction

One tailroom token, consumed by one component. F-BC-04's direction still holds: make CtaBar a thin wrapper over BottomActionBar, give that component the design's 14 / 20 / 30 padding and its 12 dp gap, and delete the per-caller re-padding. The wizard, the artist profile and Data export should all end up on the same component.

Worth handling the navigation-bar inset once in that component rather than per caller, since that is the most likely source of the drift.

Acceptance

Walk the five screens and measure the gap under each button. One number, and it is 30 dp plus whatever the system's bottom inset adds.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions