[design change] Artist profile: the bottom dock misses the design on four of its five paddings

[cestercian]

Measured on the artistant AVD (Pixel 6, 420 dpi = 2.625 px/dp) on main@229569e. Method and raw screenshots: docs/design-qa/spacing.

What is wrong

The dock that carries the message circle and the "Check availability" CTA misses the design on four of its five paddings. The one that is right is the trailing edge, which is what makes the asymmetry visible: the CTA ends exactly on the 20 dp gutter while the circle starts 24.4 dp in.

	Measured	Design 04	Off by
left padding	24.4 dp	20	+4.4
right padding	20.2 dp	20	✓
gap, circle to CTA	16.4 dp	12	+4.4
top, hairline to CTA	25.9 dp	14	+11.9
bottom, CTA to screen edge	15.2 dp	30	−14.8

The circle itself measures 52.2 dp against the design's 52, and the CTA is 54.1 dp tall against 52 — those two are close enough to leave alone.

What the design says

<div style="position:absolute;bottom:0;left:0;right:0;
            padding:14px 20px 30px;
            background:rgba(255,255,255,.96);
            border-top:1px solid rgba(20,21,15,.1);
            display:flex;align-items:center;gap:12px">
  <div style="width:52px;height:52px;flex:none;border-radius:50%;
              border:1px solid rgba(20,21,15,.14)">…</div>
  <div style="flex:1;height:52px;border-radius:15px;background:#d6f84b">Check availability · ₹42,000</div>
</div>

So: 14 px top, 20 px sides, 30 px bottom, 12 px gap. The app has the top and bottom close to inverted — it puts 25.9 above the CTA and 15.2 below it, where the design puts 14 above and 30 below.

The bottom number matters most on a gesture-nav device: the design reserves 30 px so the CTA clears the home-indicator zone, and 15.2 dp puts it noticeably closer to the edge than intended.

Where

app/src/main/java/in/artistant/app/feature/artist/ArtistProfileScreen.kt — the dock's own padding, and the Arrangement.spacedBy between the circle and the CTA.

Worth checking the other docks in the same pass: feature/booking/BookingChrome.kt (CtaBar) and designsystem/component/BottomActionBar.kt are the two pinned bars #180 already flags as having different tailroom. If they share one token, all three land together.

Acceptance

adb shell am start -S -n in.artistant.app/.MainActivity -e uitest "reset,skip-signup-as-client,seed-fixture-data,seed-open-quote"

Open any artist from Discover. The circle's left edge and the CTA's right edge sit at the same distance from their screen edges, and the space under the CTA is roughly twice the space above it.

[cestercian]

Peer measurement, from the second pass over the pushed settings screens.

Data export has the same kind of pinned CTA bar, and the two disagree:

Dock	Side padding	Bottom padding
Artist profile	24.4 dp left / 20.2 dp right	15.2 dp
Data export	20.2 dp / 20.2 dp	24.0 dp
Design 04	20 / 20	30

So Data export is symmetric and closer to the design, and the artist-profile dock is the one that drifts on both axes. That corroborates F-BC-04 in #180 ("Two pinned bars with different tailroom") with numbers off the glass — if these end up sharing one tailroom token, all three land together.

🤖 Addressed by Claude Code

[cestercian]

Partially addressed by #197: the dock's vertical padding moved from space.md to space.lg, so the gap under the CTA went from 15.2 dp to 19.0 dp.

Left open because three of the four measurements in the issue are untouched:

	Now	Design 04
left padding	24.4 dp	20
right padding	20.2 dp	20
gap, circle to CTA	16.4 dp	12
bottom	19.0 dp	30

The left/right asymmetry and the 16.4 dp gap are still there, and 19.0 is still short of 30. Those land properly when this dock moves onto the shared component — see #195 and F-BC-04 in #180.

🤖 Addressed by Claude Code