fix(registration): enforce server-side closure - #4
Conversation
|
@greptileai review |
Independent security reviewCurrent state/checks: OPEN; Findings: No blocking issue found. The fail-closed check runs at the top of the public POST handler, before body parsing, rate-limit writes, FACEIT calls, file writes, or database inserts. The absent/false case is covered with a route-level 410 assertion, and deployment documentation makes the required restart explicit. Residual/informational: This changes deployment behavior: environments that do not set exactly |
|
Addressed the integration review in 43e6551: merged current main without rewriting history, kept the fail-closed registration guard before body parsing and side effects, and preserved the deployed active-claim migration/tests. CI is rerunning on the reconciled head; I will treat that fresh run, not the stale pre-merge run, as authoritative. |
…n-api # Conflicts: # scripts/check-security.ts
Summary
Problem
The public form can be hidden while the API remains directly callable. That lets submissions bypass the intended registration window.
Validation
Deployment note
Set REGISTRATIONS_OPEN=true only during an active registration window and restart the service after changing it.