Relax OS distro check to support CentOS and RHEL >=7.4 - #88
Merged
Merged
Conversation
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Contributor
|
@dillaman I had this PR which removes the specific kernel and OS checks. We still check for specific packages, but instead of checking for a kernel version we rely on tcmu-runner/rtslib/kernel to export and detect the features needed and return errors for specific features accordingly. For a short term fix I think your patch is fine, but longer term I would like to remove the rpm specific checks and also the kernel/distro checks. |
mikechristie
approved these changes
Mar 30, 2018
Author
|
@mikechristie I definitely prefer your PR's style for the longer term solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dillaman dillaman@redhat.com