fix(typing): Fix *nodes type annotations in CeleryTestCluster#476
Merged
Nusnus merged 2 commits intocelery:mainfrom Mar 2, 2026
Merged
fix(typing): Fix *nodes type annotations in CeleryTestCluster#476Nusnus merged 2 commits intocelery:mainfrom
Nusnus merged 2 commits intocelery:mainfrom
Conversation
The *args type annotation describes each individual argument, not a tuple. Changed *nodes: tuple[CeleryTestNode | CeleryTestContainer] to *nodes: CeleryTestNode | CeleryTestContainer across __init__, _set_nodes, and nodes setter. Also fixed tuple return types to use tuple[X, ...] for variable-length tuples. Removed all related # type: ignore comments from fixtures and examples that were suppressing the resulting arg-type errors.
The _set_nodes method has a concrete implementation in CeleryTestCluster but was marked @AbstractMethod, causing mypy [abstract] errors when instantiating subclasses (CeleryBrokerCluster, CeleryBackendCluster, CeleryWorkerCluster) that don't override it.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #476 +/- ##
==========================================
+ Coverage 23.71% 23.75% +0.03%
==========================================
Files 41 41
Lines 1303 1301 -2
Branches 78 78
==========================================
Hits 309 309
+ Misses 967 965 -2
Partials 27 27 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The *args type annotation describes each individual argument, not a tuple. Changed *nodes: tuple[CeleryTestNode | CeleryTestContainer] to *nodes: CeleryTestNode | CeleryTestContainer across init, _set_nodes, and nodes setter. Also fixed tuple return types to use tuple[X, ...] for variable-length tuples.
Removed all related # type: ignore comments from fixtures and examples that were suppressing the resulting arg-type errors.