Skip to content

Revert pycurl removal to match celery/kombu v5.6 SQS transport#474

Merged
Nusnus merged 1 commit intocelery:mainfrom
Nusnus:sqs-revert-hotfix
Mar 2, 2026
Merged

Revert pycurl removal to match celery/kombu v5.6 SQS transport#474
Nusnus merged 1 commit intocelery:mainfrom
Nusnus:sqs-revert-hotfix

Conversation

@Nusnus
Copy link
Copy Markdown
Member

@Nusnus Nusnus commented Mar 2, 2026

celery and kombu v5.6 reverted the urllib3-only change for SQS transport due to critical performance regression (kombu#2258).

  • Re-added pycurl to pyproject.toml with platform markers
  • Added pycurl to sqs and all extras
  • Added libcurl4-openssl-dev and libssl-dev to Dockerfile
  • Added celery[sqs] to Dockerfile for belt-and-suspenders coverage

@Nusnus Nusnus self-assigned this Mar 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 23.80%. Comparing base (8386670) to head (e62fcb9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #474      +/-   ##
==========================================
- Coverage   28.90%   23.80%   -5.11%     
==========================================
  Files          41       41              
  Lines        1294     1294              
  Branches       78       78              
==========================================
- Hits          374      308      -66     
- Misses        893      959      +66     
  Partials       27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Nusnus Nusnus force-pushed the sqs-revert-hotfix branch from 240d29f to c23f2b2 Compare March 2, 2026 14:10
celery and kombu v5.6 reverted the urllib3-only change for SQS
transport due to critical performance regression (kombu#2258).

- Re-added pycurl to pyproject.toml with platform markers
- Added pycurl to sqs and all extras
- Added libcurl4-openssl-dev and libssl-dev to Dockerfile
- Added celery[sqs] to Dockerfile for belt-and-suspenders coverage
@Nusnus Nusnus force-pushed the sqs-revert-hotfix branch from c23f2b2 to e62fcb9 Compare March 2, 2026 14:18
@Nusnus Nusnus marked this pull request as ready for review March 2, 2026 14:38
@Nusnus Nusnus merged commit c045029 into celery:main Mar 2, 2026
47 of 48 checks passed
@Nusnus Nusnus deleted the sqs-revert-hotfix branch March 2, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant