Chore: Move static metadata to pyrpoejct.toml - #505
Open
dpgraham4401 wants to merge 13 commits into
Open
Conversation
…s 'build' package which allows us to pull metadata and build inormation from both pyproject.toml and setup.py
…, if it's not found, it falls back to setup.py's metadata
…t URLs and verify that build dist.info is idnetical
… entry points to pyrpoject.toml and verify that build dist.info is idnetical
for more information, see https://pre-commit.ci
dpgraham4401
marked this pull request as ready for review
April 5, 2026 03:00
auvipy
reviewed
Apr 5, 2026
| @@ -1,17 +0,0 @@ | |||
| [bumpversion] | |||
Member
There was a problem hiding this comment.
this is wrong. please revert this. also it would be best to abandon this pr. there are many open bug reports, you can work on those.
Author
There was a problem hiding this comment.
also it would be best to abandon this pr.
Got it. I'll abandon this PR since, based on this, I don't expect this PR will get merged.
this is wrong. please revert this.
I've reverted it. But bumpversion hasn't been maintained for so long that it's successor project bump2version is also no longer maintained. This PR would have moved the project to the grandchild successor project bump-my-version which can be configured in toml format and doesn't need this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This PR is a part of an incremental migration from
setup.pytopyproject.toml, currently this PR adds all static metadata fields to but keeps the project dependencies as dynamic fields inpyproject.tomland use the current set up withsetup.pyand the existing requirements text files.setup.py/__init__.pytopyproject.tomlbumpmyversionto forkbump-my-versionMakefilemake testruns pytest directlymake buildis aPHONYtarget and uses the PYPA's build package to pull date from bothsetup.pyandpyproject.toml