fix(host): do not attach acquire to a stopped autopg port - #36
Open
simoncrypta wants to merge 1 commit into
Open
fix(host): do not attach acquire to a stopped autopg port#36simoncrypta wants to merge 1 commit into
simoncrypta wants to merge 1 commit into
Conversation
Registered pm2 with no listener was treated as live, so cedarpg acquire hit ECONNREFUSED on 25432. Treat status/TCP as liveness and start an owned postmaster when local install cannot bring a host up.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cedarpg acquire --forceno longer treats a registered-but-stopped autopg (pm2status: stopped, port 25432) as live, which producedECONNREFUSED 127.0.0.1:25432.autopg postmasteronly (noinstall --no-pm2, so~/.autopg/admin.jsonis left alone).autopg install, then an owned postmaster on 55432 if install fails or still has no listener.CEDAR_PG_EPHEMERAL_HOST=0keeps the fail-closed pm2 path.Test plan
vp checkandvp test(86)cedarpg acquire --forcewith autopg stopped, noCI/CEDAR_PG_EPHEMERAL_HOST→ URL on 55432, not 25432CEDAR_PG_EPHEMERAL_HOST=0still fails and does not start 55432vp run smoke:pg(Vitest, Jest, CLI acquire/run/dispose)~/.autopg/admin.jsonunchanged next to local pm2