Fix precision information in numerics docs #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| | `numeric(18, 0)` | -999999999999999999 | 999999999999999999 | 8 Byte | | ||
| | `numeric(18, 3)` | -999999999999999.999 | 999999999999999.999 | 8 Byte | | ||
| | `numeric(38, 0)` | -99999999999999999999999999999999999999 | 99999999999999999999999999999999999999 | 16 Byte | | ||
| | `numeric(38, 6)` | -99999999999999999999999999999999.999999 | 99999999999999999999999999999999.999999 | 16 Byte | |
Contributor
There was a problem hiding this comment.
In Cedar, inserting bigger/smaller values is possible, see cedardb/cedardb#2619 , but I agree that this range is what we would want to do.
@bandle should we update the documentation now or make sure that we always check the numeric precision?
Contributor
Author
There was a problem hiding this comment.
Good point, and I'm a bit concerned that this is tricky to fix properly without touching the definition of precision. Consider this query:
SELECT 99999999999999999999999999999999999999::numeric(38, 0) + 1 - 1;
Restricting numerics to the entered precision would (probably) require checks after every arithmetic operation..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation on numeric precision is now adjusted to the current behavior of cedardb and better highlights differences to postgres numerics.