BUILD_ENV_INPUT: rootpath instead of location#16
Open
matoubidou wants to merge 1 commit intocedarai:mainfrom
Open
BUILD_ENV_INPUT: rootpath instead of location#16matoubidou wants to merge 1 commit intocedarai:mainfrom
matoubidou wants to merge 1 commit intocedarai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for this easy-to-use bazel rules for creating python virtual envs. When I was trying to use your rules from rules_multirun, i.e.
, I ran into
. This is caused by the funny behavior of
location, see make variable documentation for details. I now fixed things by usingrootpathinstead. When I get things right this fix won't work on windows or when doing cross-compilation builds - but I doubt that this is needed for a venv.For me things are working using it wrapped by multienv as well as invoking it directly.
Mathias Zeller mathias.zeller@mercedes-benz.com Mercedes-Benz Tech Innovation GmbH (ProviderInformation)