This repository was archived by the owner on Sep 10, 2020. It is now read-only.
Switch to showing script tags in library listing to increase use of SRI#315
Open
Switch to showing script tags in library listing to increase use of SRI#315
Conversation
MattIPv4
suggested changes
Dec 6, 2019
Member
MattIPv4
left a comment
MattIPv4
left a comment
There was a problem hiding this comment.
This needs some logic added so that it does the following:
- If a JS file: show the script tag
- If a CSS file: show the link tag
- If something else: just show the url
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal of this change is to increase usage of SRI by showing the full script tag rather than just the URL by default.