Allow "hitsPerPage" and "page" query parameters#192
Allow "hitsPerPage" and "page" query parameters#192tholman wants to merge 5 commits intocdnjs:masterfrom tholman:master
Conversation
|
Any questions/clarifications needed here? I'm happy to chat. |
|
Anywhere I can drop a few $'s to get this & #191 looked at? :) cc @PeterDaveHello |
PeterDaveHello
left a comment
There was a problem hiding this comment.
Thanks for the pull request and sorry for the late review!
There are few empty line changes not related to the function itself, please revert it.
I have only two concerns here:
- Would
hitsPerPagebe appropriate enough or can we use something more friendly thanhitshere? - A little bit familiar with the above issue, I wonder how many websites using page = 0 as the first page in the parameter? What do you think about we treat 1 as the first page and just minus one and then send to API?
I went with
Same point here as with the |
This PR allows the apiServer to pass through
hitsPerPageandpagequery params, as per the Algolia apiIncludes:
apiServer.jsto allow the passing of the params