Skip to content

dev: eh #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdcabrera merged 2 commits into from
May 13, 2026
Merged

dev: eh #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9296dcd
dev: eh
cdcabrera May 13, 2026
1fe2edc
dev: remove draft attempt
cdcabrera May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion bin/t2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@ const doIt = () => {
console.log(`t1: ${output.join(', ')}`);
};
// comment change
// another comment
doIt();
36 changes: 11 additions & 25 deletions scripts/workflow.preCheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,25 +308,6 @@ const setComment = async ({ signature, github, context } = {}) => {
};
};

/**
* Convert a PR to draft.
*
* @param config
* @param config.github
* @param config.context
* @returns {Promise<any>}
*/
const convertPrToDraft = async ({ github, context } = {}) => {
const prNodeId = context.payload.pull_request.node_id;
const mutation = `mutation($id: ID!) {
convertPullRequestToDraft(input: { pullRequestId: $id }) {
pullRequest { id isDraft }
}
}`;

return github.graphql(mutation, { id: prNodeId });
};

/**
* Get a pull request context.
*
Expand Down Expand Up @@ -371,6 +352,7 @@ const getPullRequest = async ({ github, context } = {}) => {
* @param config.LABEL_NEEDS_CLEANUP - Label string
* @param config.LABEL_NEEDS_MAINTAINER - Label string
* @param config.LABEL_PRECHECKS_PASS - Label string
* @param config.LABEL_PRECHECKS_FAIL - Label string
* @param env - Environment params
* @param env.github
* @param env.context
Expand All @@ -380,7 +362,8 @@ const getPullRequest = async ({ github, context } = {}) => {
const start = async ({
LABEL_NEEDS_CLEANUP,
LABEL_NEEDS_MAINTAINER,
LABEL_PRECHECKS_PASS
LABEL_PRECHECKS_PASS,
LABEL_PRECHECKS_FAIL
} = {}, { github, context, core } = {}) => {
const { author, authorType, authorRole, description: prDescription, fileCount: prFileCount, files: prFiles } = await getPullRequest({ github, context });
const { add: addLabels, remove: removeLabels } = await setLabels({ github, context });
Expand All @@ -400,15 +383,18 @@ const start = async ({

if (codeSignature.hasTell) {
const botComment = `### 🤖 PR Quality Guidance\n` +
`I've moved this to **Draft** due to the scope of changes, and to avoid confusion.\n` +
`I've flagged this PR for a **Policy Hold** due to a "Perfect Storm" of identified issues (core modifications, excessive scope, and template changes).\n\n` +
`**To resolve this hold**:\n` +
`- Ensure all updates are associated with a GitHub issue.\n` +
`- Align to the codebase style and remove excessive changes.\n` +
`- Split changes into smaller, focused PR contributions.\n\n` +
`Once you've focused your changes I'll take another look.\n\n` +
`_Read our [contribution guidelines](https://github.com/patternfly/patternfly-mcp/blob/main/CONTRIBUTING.md). This comment updates automatically._`;

await convertPrToDraft({ github, context });
await addBotComment(botComment);
await addLabels([LABEL_NEEDS_CLEANUP]);
await addLabels([LABEL_NEEDS_CLEANUP, LABEL_PRECHECKS_FAIL]);

core.setFailed('PR moved to Draft. Make sure to review the contributing guidelines regarding potential feature and generated work and why your PatternFly MCP contribution may require planning.');
core.setFailed('PR placed on Policy Hold. Make sure to review the contributing guidelines regarding potential feature and generated work and why your PatternFly MCP contribution may require planning.');

return;
}
Expand Down Expand Up @@ -449,7 +435,7 @@ const start = async ({

await addBotComment(successComment);
await addLabels([LABEL_PRECHECKS_PASS]);
await removeLabels([LABEL_NEEDS_CLEANUP, LABEL_NEEDS_MAINTAINER]);
await removeLabels([LABEL_NEEDS_CLEANUP, LABEL_NEEDS_MAINTAINER, LABEL_PRECHECKS_FAIL]);
}
};

Expand Down
Loading