Clippy/use self#184
Draft
danieleades wants to merge 2 commits into
Draft
Conversation
danieleades
force-pushed
the
clippy/use-self
branch
from
2c3a669 to
9c6358e
Compare
Collaborator
|
@danieleades #183 has been merged. By the way, thank you for all your latest contributions. |
danieleades
force-pushed
the
clippy/use-self
branch
from
9c6358e to
ff01f7f
Compare
danieleades
force-pushed
the
clippy/use-self
branch
from
ff01f7f to
644462a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
use 'Self' to refer to own type.
This is less verbose, easier to refactor, and makes it clear that a method is a 'constructor'.
this PR is stacked on #183, will leave it as a draft until it can be rebased.