fix: preserve TPEx market in Yahoo OHLCV fallback (#481)#497
Merged
cct08311github merged 1 commit intomainfrom Mar 28, 2026
Merged
fix: preserve TPEx market in Yahoo OHLCV fallback (#481)#497cct08311github merged 1 commit intomainfrom
cct08311github merged 1 commit intomainfrom
Conversation
- fetch_ohlcv_yahoo: accepts market_map param; TPEx symbols use .TWO suffix, TWSE symbols use .TW - run_daily_fetch: builds symbol→market lookup from existing eod_prices; TPEx symbols skip TWSE STOCK_DAY, go directly to Yahoo fallback - Yahoo INSERT uses parameterized :market instead of hardcoded 'TWSE' - 4 new regression tests in TestTPExYahooFallback (55 total) Fixes #481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fetch_ohlcv_yahoo(): TPEx symbols now use.TWOsuffix (was.TWfor all)run_daily_fetch(): builds symbol→market lookup, TPEx symbols skip TWSE STOCK_DAY and go directly to Yahoo:marketpreserving original market (was hardcoded'TWSE')Root Cause
Commit
6608f5cadded Yahoo fallback but hardcodedmarket='TWSE'and.TWsuffix for all symbols. TPEx symbols (89,507 rows in eod_prices) were being mislabeled and fetched from wrong Yahoo endpoint.Test plan
TestTPExYahooFallbacktest_market_data_fetcher.py: 55/55 passedFixes #481
🤖 Generated with Claude Code