refactor: final batch — proposal_engine migration (closing refactoring series)#491
Merged
cct08311github merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
Migrate 6 SQL operations in proposal_engine.py: - approve_proposal → repo.update_decision() - reject_proposal → repo.update_decision() - _expire_proposal → repo.update_decision() - expire_old_proposals → repo.expire_pending_proposals() - apply_authority_decision → repo.update_status() ProposalRepository.update_status enhanced with schema-safe decided_at handling (PRAGMA table_info check). All 2503 tests pass (0 failures). https://claude.ai/code/session_011LhoTJuk5FAaZMaHVzWC41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
重構系列完工總結
累計成果：
Test plan
python -m pytest— 2503 passed, 0 failedhttps://claude.ai/code/session_011LhoTJuk5FAaZMaHVzWC41