fix(ci): use absolute path in NuGet smoke test#732
Merged
cct08311github merged 1 commit intodotnet10from Mar 28, 2026
Merged
Conversation
The --source parameter in `dotnet add package` was passed the source name "local-nupkgs" which NuGet resolves as a relative path from the current working directory (smoke/). After `cd smoke`, this becomes smoke/local-nupkgs which doesn't exist. Fix: use $NUPKG_DIR (absolute path via env var) for --source on all three `dotnet add package` calls. Also moves github.workspace into an env var per GitHub Actions security best practices. Fixes #731 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--source local-nupkgs(source name) was resolved as a relative path aftercd smoke→ use$NUPKG_DIRabsolute path insteadgithub.workspaceinto env var per GitHub Actions security best practicesImpact
Fixes #731