Skip to content

Turn main green again and pin the arm64 base as published - #340

Merged
ccozianu merged 6 commits into
ccozianu:mainfrom
powerofsoul:ws-linux-arm64/mirror-and-published-base
Nov 4, 2026
Merged

ccozianu merged 6 commits into
ccozianu:mainfrom
powerofsoul:ws-linux-arm64/mirror-and-published-base

Conversation

@powerofsoul

@powerofsoul powerofsoul commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

#338 went in from dcc2a7db, three commits short of the branch's tip, and main has been red since: the test-conventions gate counts 115 breaches, the tests that work added or changed inside legacy files. This brings in the rest, pins the arm64 base as published now that it is on Docker Hub, and lets a pull request from a fork pass CI.

What's here

  • The three commits that missed the merge, unchanged: the fit to main's non-Docker marker set and its e2e builder calls, the move of every test the branch added or changed into tests/unit with a contract docstring, and the record of both.
  • main's Linux-only skips stay. main now carries the skips that the move had taken out of test_host_open.py, test_recursive_orchestrator.py and test_supervisor.py, and taking them out again would change legacy tests. The macOS host-browser test leaves test_host_open.py, since the mirror holds the same test. test_supervisor.py assigned pytestmark twice and so lost its legacy marker; the two marks are one list now.
  • The arm64 base is published. It went up as mycodespaceai/devcapsule-base:linux-arm64-recipe-11-20261104, the exact image the six native IDE smokes ran on, and the registry returns the pinned digest sha256:7d32268065b6… for linux/arm64. The pin and its verified edges don't move. With no unpublished base left, the pin's published flag, init's note about it and the launch's refusal to pull it are gone, and the macOS page no longer asks you to build a base and select it per checkout.
  • Coverage numbers from a fork. A pull request from a fork runs with a read-only GITHUB_TOKEN, whatever the job asks for, so the step that writes the coverage numbers into the description got HTTP 403 and failed this PR after the conventions check and every test had passed. That step now runs only when the PR's branch is in this repository; for a fork, the job summary and the uploaded reports still carry the figures.

Validation

  • Test conventions against today's main: 108 legacy files holding 1,461 tests, 22 conforming files, 0 breaches.
  • mypy: no issues in 302 files.
  • Unit suite in a linux/amd64 container: 2,820 passed, 5 failed, the five recursive-dogfood tests that fail on main in the same container, which has no host X11 directory, runs as root and has no Docker group. They pass on CI's runners.
  • Unit suite on an Apple Silicon Mac: 2,800 passed, 1 failed, test_broker_rejects_a_different_peer_uid, a Linux-only legacy test that fails on main on a Mac as well.
  • docker buildx imagetools inspect on the pinned digest shows an OCI index with linux/arm64 and its attestation, and docker pull --platform linux/arm64 by that digest resolves to the recipe-11 arm64 image.

🤖 Generated with Claude Code

https://claude.ai/code/session_013kivdG1oNN7W4zZ12jHFEG

powerofsoul and others added 6 commits November 4, 2026 17:31
… calls

main's mirrored marker test knows the non-Docker markers; own_host_patches
is one. The component-cache end-to-end tests call the image builder, whose
platform is now required: the host's native one, as they built before.
main also type-checks the tests, which caught that and an Optional index in
the arm64 matrix test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
main's unit-test conventions let a legacy test file only lose tests. Every
test this branch added or changed now lives in tests/unit beside the
module it tests, with a docstring stating its contract:

- the launcher's 47 tests, and the configuration tests of the same
  boundary, now creating their own project instead of the released
  checkout fixture;
- platforms, runtime_artifact, storage, operations, owner_commands,
  capability_selection, resolution_matrix, the arm64 pins, the image
  builders, environment realization, the successor plan, host_open and
  the --platform argument type;
- tests that made several calls split into one test per call.

The two end-to-end files the branch changed follow the convention in
place, marked e2e at module level. The Linux-only skips this branch had
added to three legacy files are gone, as legacy files take no new
marker; those tests fail on a Mac exactly as they do on main.

test conventions: 108 legacy files holding 1461 legacy tests; 22 files
follow the convention; 0 breaches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013kivdG1oNN7W4zZ12jHFEG
ccozianu#338 merged this work before its move into the unit mirror, so main's
legacy test_host_open, test_recursive_orchestrator and test_supervisor
carry the Linux-only skips that the move took out against the older
main. Taking them out now would change legacy tests, so they stay. The
macOS host-browser test leaves test_host_open.py, since the mirror
holds the same test.

test_supervisor.py assigned pytestmark twice, and the second assignment
dropped the legacy marker; the two marks are now one list.

test conventions: 108 legacy files holding 1461 legacy tests; 22 files
follow the convention; 0 breaches.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013kivdG1oNN7W4zZ12jHFEG
This Mac's arm64 recipe-11 base was pushed as
mycodespaceai/devcapsule-base:linux-arm64-recipe-11-20261104, and the
registry returns the pinned index digest, sha256:7d32268065b6..., for
linux/arm64, so the pin and its six verified edges stand unchanged.

The pin's published flag, init's note and report line about an
unpublished base, and the launch's refusal to pull one served only
this base until its push, so they are removed: an arm64 checkout pulls
its base as an amd64 one does. The macOS page no longer builds or
selects a local base, and says how a checkout that selected one
returns to the project's base.

The records note ccozianu#338: linux-arm64 and macos-launcher are on main, and
this branch turns main's CI green again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013kivdG1oNN7W4zZ12jHFEG
…nches

A pull request from a fork runs with a read-only GITHUB_TOKEN whatever
the job asks for, so the step that writes the coverage numbers into the
description is refused with HTTP 403 and fails the pull request: ccozianu#340,
from a fork, passed the conventions check and every test and still
went red. The step now runs when the pull request's branch is in this
repository; for a fork the job summary and the uploaded reports keep
the figures.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_013kivdG1oNN7W4zZ12jHFEG
@ccozianu
ccozianu merged commit cc8f128 into ccozianu:main Nov 4, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants