Skip to content

User local fixes: simplify extension and add scroll fix#3

Open
cclambie wants to merge 2 commits intoinitial-uploadfrom
feature/user-local-fixes
Open

User local fixes: simplify extension and add scroll fix#3
cclambie wants to merge 2 commits intoinitial-uploadfrom
feature/user-local-fixes

Conversation

@cclambie
Copy link
Copy Markdown
Owner

Summary

This PR includes local changes made by the user to simplify the extension and fix scrolling behavior.

Changes Made

1. Simplified content.js

  • Removed MutationObserver code: The extension no longer uses MutationObserver to watch for table changes, simplifying the codebase
  • Cleaned up filter state management: Removed global filter state that was used for persistence
  • Minor code cleanup: Removed some event propagation stops and simplified logging

2. Added fix.css

  • New CSS file to address scrolling issues
  • Prevents page scroll when grid reaches boundaries using overscroll-behavior: contain
  • Improves grid scrolling by making the scroller a proper scroll container with overflow-y: auto
  • Sets max-height to 70vh for better viewport management

3. Updated manifest.json

  • Version bump: 1.0.0 → 1.0.1
  • Added fix.css to the content scripts CSS array

Files Changed

  • content.js - Simplified by removing MutationObserver logic
  • fix.css - New file for scroll behavior fixes
  • manifest.json - Version bump and CSS file addition

Testing Recommendations

  • Test that filters still work correctly without MutationObserver
  • Verify that scrolling behavior is improved with the new CSS
  • Ensure the extension loads properly with the updated manifest

Xero Filter Bot added 2 commits November 30, 2025 23:44
- Removed MutationObserver code from content.js to simplify extension
- Added fix.css to fix page scroll behavior when grid reaches boundaries
- Bumped version to 1.0.1 in manifest.json
- Updated manifest to include fix.css in content scripts
…ve logging

- Added 4 fallback strategies to find display count element
- Strategy 1: Check all span.total elements for visibility
- Strategy 2: Search in action-bar area
- Strategy 3: Search near Show more button
- Strategy 4: Search entire page for pattern
- Increased timeout from 10s to 30s in waitForRowsToLoad
- Added detailed console logging for debugging
- Added attempt counter and elapsed time logging
- Improved error messages with more context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant