Repository navigation
Count building PINs correctly - #26
Merged
Merged
Conversation
wrridgeway
commented
Oct 21, 2026
Comment on lines
+4
to
+15
| WITH pins AS ( | ||
| SELECT | ||
| SUBSTR(parid, 1, 10) AS pin10, | ||
| taxyr AS year, | ||
| COUNT(*) AS pins | ||
| FROM iasworld.pardat | ||
| WHERE cur = 'Y' | ||
| AND deactivat IS NULL | ||
| GROUP BY | ||
| SUBSTR(parid, 1, 10), | ||
| taxyr | ||
| ) |
Member
Author
There was a problem hiding this comment.
Unfortunately none of the views we join on already include a PIN or unit count, and window functions are slow, so I decided to use pardat to make this calculation as resource light as possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My last iteration of this output counted the number of building units that would appear in the output, rather than the total number of units that are actually in a condo building. This PR fixes the count, but also shifts from units to PINs, just to make sure there's no confusion as to what's being counted.
Updated output here: O:\CCAODATA\recurring-data-requests\condo-chars-prep\output\city_condo_review_2026.xlsx