Create pdf report of on demand ratio analyses by Damonamajor · Pull Request #21 · ccao-data/recurring-data-requests

Damonamajor · 2026-08-24T17:23:24Z

Draft can be found here:

O:\CCAODATA\tmp\ratio-analysis.pdf

Damonamajor · 2026-08-24T17:27:53Z

@wrridgeway Take a quick look at the output and see if anything stands out. After that we can do a code review.

Damonamajor · 2026-08-24T17:30:05Z

In the quick edit round, I also added a table for descriptive stats, which makes the initial text kind of obsolete. Just left in both for now.

ccao-jardine

Great work so far, @Damonamajor! Some comments here for your next iteration.

Co-authored-by: Nicole Jardine <138712135+ccao-jardine@users.noreply.github.com>

ccao-jardine · 2026-08-25T14:05:29Z

Oh, one more request @Damonamajor: in the intro paragraph, can we list the modeling groups (Single-Family, Multi-Family, Condo?) and/or the class codes that the ratio analysis entails?

Damonamajor · 2026-08-25T20:44:46Z

Oh, one more request @Damonamajor: in the intro paragraph, can we list the modeling groups (Single-Family, Multi-Family, Condo?) and/or the class codes that the ratio analysis entails?

They come from the res model. Is that considered single and multi family?

Damonamajor · 2026-08-25T20:54:04Z

New file is in the sale shared drive. Didn't make changes on the last question since I didn't know how it should be stated.

ccao-jardine

Thanks for continuing your work on this!

Co-authored-by: Nicole Jardine <138712135+ccao-jardine@users.noreply.github.com>

…thub.com:ccao-data/recurring-data-requests into 19-create-pdf-report-of-on-demand-ratio-analyses

Damonamajor · 2026-08-28T15:47:52Z

New file is uploaded

Damonamajor · 2026-09-08T20:35:57Z

+# Extracts low and high bounds from each assessr *_met function body
+met_bounds <- function(fn) {
+  b <- body(fn)
+  c(low = eval(b[[2]][[3]]), high = eval(b[[3]][[3]]))


There's not a great way to take the bounds from the function (as far as I can think of). Billy may have thoughts on it.

Oh, I actually liked in your previous versions that you hard-coded the IAAO Standard goal ranges, instead of creating another function that references something confusing -- I think it made it much easier to understand what was going on. (Sorry if I wasn't clear! I just wanted to use assessr's prd_met function to determine the TRUE/FALSE boolean of whether the PRD standard was met, which you did implement.)

I'll leave this comment for Billy's review and let him be the great decider on the cleanest way to do this!

yeah, i think just hard-coding them is preferable. i do appreciate the effort to use assessr and make sure the values align with what we've formalized, though.

ccao-jardine

Good work taking a stab at a chunky project! I'm ready to hand over the reins but left a couple comments.

@wrridgeway, tagging you in for review! This is a pretty big boi. I'll let you decide whether you want to review this for correctness only and merging and then doing a PR of your own for Damon's review, or a different way to do this.

Thanks, this is looking solid!

ccao-jardine · 2026-09-08T21:42:26Z

+# Extracts low and high bounds from each assessr *_met function body
+met_bounds <- function(fn) {
+  b <- body(fn)
+  c(low = eval(b[[2]][[3]]), high = eval(b[[3]][[3]]))


Oh, I actually liked in your previous versions that you hard-coded the IAAO Standard goal ranges, instead of creating another function that references something confusing -- I think it made it much easier to understand what was going on. (Sorry if I wasn't clear! I just wanted to use assessr's prd_met function to determine the TRUE/FALSE boolean of whether the PRD standard was met, which you did implement.)

I'll leave this comment for Billy's review and let him be the great decider on the cleanest way to do this!

wrridgeway · 2026-09-09T14:45:36Z

While I'm reviewing this, could we add a readme like we have in the other recurring data request folders?

Damonamajor · 2026-09-09T15:07:55Z

For Billy's reference

Oh, I actually liked in your previous versions that you hard-coded the IAAO Standard goal ranges, instead of creating another function that references something confusing -- I think it made it much easier to understand what was going on. (Sorry if I wasn't clear! I just wanted to use assessr's prd_met function to determine the TRUE/FALSE boolean of whether the PRD standard was met, which you did implement.)

would be something like this

metric_meta <- tibble(
  name = c("Median Ratio", "COD", "PRD", "PRB", "MKI"),
  digits = c(2, 2, 2, 2, 2),
  lo = c(0.90, 5.0, 0.98, -0.05, 0.95),
  hi = c(1.10, 15.0, 1.03, 0.05, 1.05),
  mid = c(1.000, 10.0, 1.005, 0.00, 1.000),
  half_span = c(0.100, 5.0, 0.025, 0.05, 0.100),
  standard_label = c(
    "0.90 -- 1.10", "5.0 -- 15.0", "0.98 -- 1.03", "$\\pm$0.05", "0.95 -- 1.05"

wrridgeway

The values from the Bremen report all seem to align with the values from the old report so looks good! I've got some suggestions below, but nothing major. Obviously this is a ton of work and we haven't done much PDF output in the past, so awesome job on that. I leave graph presentation to you two, but I will say, this graph is a little chaotic and hard to read if you don't already know what you're looking for:

Thoughts:

The line labels for figure 5 worked better in the HTML and we might need to try using something like ggrepel to help us out here.
We should start using gt() rather than kable()
All tables and graphs are labeled as "Figure" in the output, not sure how easy (or possible) it is to get the tables to actually be labeled as tables using cross-referencing.

wrridgeway · 2026-09-09T15:15:24Z

Could we get some commenting in this file?

Yup, do you also have preferences on what we name the files and where they are stored? We talked briefly about it, but I don't know what conclusion was reached.

[Question, non-blocking] Hijacking this thread to discuss file naming and folder structure:

File names look fine to me! The directory name ratio-analysis/ also seems reasonable, but I wonder if it would make more sense to nest this directory under provisional-ratio-curves/ (i.e. provisional-ratio-curves/ratio-analysis/) since it seems like the two projects are related? I don't have full context into this work, so admittedly I may be misinterpreting the relationship between the two projects; if you feel strongly about keeping them separate, that's fine by me too.

wrridgeway · 2026-09-09T18:44:14Z

+# Extracts low and high bounds from each assessr *_met function body
+met_bounds <- function(fn) {
+  b <- body(fn)
+  c(low = eval(b[[2]][[3]]), high = eval(b[[3]][[3]]))


yeah, i think just hard-coding them is preferable. i do appreciate the effort to use assessr and make sure the values align with what we've formalized, though.

wrridgeway · 2026-09-09T19:56:12Z

+#|   Fair Market Values by Group.\newline Model and desk review fair
+#|   market values for properties with qualifying arm's-length sales
+#|   (Sold), properties without a recorded sale (Unsold), and all
+#|   residential parcels (All). Sold and Unsold do not sum to All
+#|   because properties removed by desk review as outliers are counted
+#|   in All but neither in Sold nor Unsold.


Perhaps we could add an "Excluded" group as well so the counts add up?

Just commenting for posterity! We did make this change to add an "Excluded" group, but it produced a confusing summary. Because Excluded PINs are no longer represented in the FMV data, they were showing up as having null FMVs, 0 changes, and 0% change in Figures 3 and 4. This is an issue because it's very likely that these PINs did have FMV changes -- it's just that these changes are hidden, because the row for the PIN's FMV is excluded from the analysis.

For this PR, we're resolving this either by not having the "Excluded" PINs in the summary tables for Figs 3 and 4, or by replacing the null, 0 change, and 0% change results with a string that says "excluded".

Edited to add: I'll let @Damonamajor decide how to proceed, as either of the above options may require some text replacement too. Then feel free to resolve this convo!

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

wrridgeway · 2026-09-10T14:17:51Z

https://r-graph-gallery.com/lollipop-plot.html

there are some cool graphs in here you guys could steal elements from. in particular i think this one has a good idea for labeling the points on figure 2.

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

jeancochrane

Just popping in to leave some feedback on folder structure and import duplication, I didn't take a serious look at the code since Billy has done that already! Wherever we decide to store the new ratio-analysis/ directory, I would also request that we create a README in the root of that directory with a brief summary describing what this project is for and how to run it.

jeancochrane · 2026-09-14T18:39:57Z

[Question, non-blocking] Hijacking this thread to discuss file naming and folder structure:

File names look fine to me! The directory name ratio-analysis/ also seems reasonable, but I wonder if it would make more sense to nest this directory under provisional-ratio-curves/ (i.e. provisional-ratio-curves/ratio-analysis/) since it seems like the two projects are related? I don't have full context into this work, so admittedly I may be misinterpreting the relationship between the two projects; if you feel strongly about keeping them separate, that's fine by me too.

ccao-jardine

Looks great, thank you!

Damonamajor · 2026-09-25T19:34:59Z

Just noting that we don't want two ratio_reports in the same folder. We will ask res-val if they want this and then decide how we want to merge it in.

…yses

Damonamajor · 2026-11-03T16:18:31Z

Adding one comment that there are unresolved issues working between trellix and local windows environments.

Damonamajor added 2 commits August 14, 2026 15:10

initial push

9e0d29c

post-Nicole updates

27c5429

Damonamajor linked an issue Aug 24, 2026 that may be closed by this pull request

Create pdf report of on-demand ratio analyses #19

Closed

Damonamajor requested a review from ccao-jardine August 24, 2026 17:27

Damonamajor marked this pull request as ready for review August 24, 2026 17:27

Damonamajor requested a review from a team as a code owner August 24, 2026 17:27

ccao-jardine requested changes Aug 24, 2026

View reviewed changes

Damonamajor and others added 2 commits August 24, 2026 16:22

Update ratio-analysis/ratio-analysis.qmd

bc0265f

Co-authored-by: Nicole Jardine <138712135+ccao-jardine@users.noreply.github.com>

Apply suggestions from code review

e1b5ad0

Co-authored-by: Nicole Jardine <138712135+ccao-jardine@users.noreply.github.com>

Damonamajor added 3 commits August 25, 2026 17:13

ordering updates

f99714c

sepearate tables

80943a5

add total av

b114b32

Damonamajor requested a review from ccao-jardine August 25, 2026 20:53

ccao-jardine requested changes Aug 26, 2026

View reviewed changes

Damonamajor and others added 9 commits August 27, 2026 10:02

Update ratio-analysis/ratio-analysis.qmd

7440731

Co-authored-by: Nicole Jardine <138712135+ccao-jardine@users.noreply.github.com>

Nicole V2 edits

c365d96

Merge branch '19-create-pdf-report-of-on-demand-ratio-analyses' of gi…

b368006

…thub.com:ccao-data/recurring-data-requests into 19-create-pdf-report-of-on-demand-ratio-analyses

switch more to mv

aa66809

remove nsales

2192052

improve text

1cd8574

updated text

9115841

improve text

e97de6f

Add text comment

bc6eec1

Damonamajor requested a review from ccao-jardine August 28, 2026 15:47

Update ratio-analysis.qmd

f566e61

Damonamajor commented Sep 8, 2026

View reviewed changes

ccao-jardine approved these changes Sep 8, 2026

View reviewed changes

ccao-jardine requested a review from wrridgeway September 8, 2026 22:13

wrridgeway approved these changes Sep 9, 2026

View reviewed changes

Damonamajor and others added 3 commits September 9, 2026 16:21

Update ratio-analysis/render_all_files.R

aabf0f2

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

Update ratio-analysis/ratio-analysis.qmd

39ae04d

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

Update ratio-analysis/ratio-analysis.qmd

0f51511

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

Billy edits

6079cde

Damonamajor commented Sep 11, 2026

View reviewed changes

Comment thread ratio-analysis/render_all_files.R Resolved

Damonamajor and others added 2 commits September 11, 2026 11:20

Apply suggestion from @wrridgeway

706541a

Co-authored-by: William Ridgeway <10358980+wrridgeway@users.noreply.github.com>

add commenting

70b2ce5

jeancochrane reviewed Sep 14, 2026

View reviewed changes

Damonamajor added 3 commits September 16, 2026 18:58

Add readme and tidy up

6748082

remove scientific notation

fd487f5

manual exclusion

a3a4a5f

ccao-jardine approved these changes Sep 18, 2026

View reviewed changes

Damonamajor and others added 6 commits October 19, 2026 20:26

remove provisional ratio curve folder

8a428b2

update the references to provisional-ratio-curves

8a7d608

add data path

cb0285e

Add data path to output

50bd7dd

update renv

0f32ded

Merge branch 'main' into 19-create-pdf-report-of-on-demand-ratio-anal…

f5745e5

…yses

Damonamajor merged commit ae8cc69 into main Nov 3, 2026
3 checks passed

Damonamajor deleted the 19-create-pdf-report-of-on-demand-ratio-analyses branch November 3, 2026 16:18

Conversation

Damonamajor commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Damonamajor commented Aug 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Damonamajor commented Aug 24, 2026

Uh oh!

ccao-jardine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ccao-jardine commented Aug 25, 2026

Uh oh!

Damonamajor commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Damonamajor commented Aug 25, 2026

Uh oh!

ccao-jardine left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Damonamajor commented Aug 28, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccao-jardine left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wrridgeway commented Sep 9, 2026

Uh oh!

Damonamajor commented Sep 9, 2026

Uh oh!

wrridgeway left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ccao-jardine Sep 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Damonamajor commented Aug 24, 2026 •

edited

Loading

Damonamajor commented Aug 24, 2026 •

edited

Loading

Damonamajor commented Aug 25, 2026 •

edited

Loading

wrridgeway left a comment •

edited

Loading

ccao-jardine Sep 16, 2026 •

edited

Loading