[wrridgeway]

This PR moves us away from the old attributes source since our current system (ias) of record seems to agree much better with tax district data from other county sources. This testing was originally performed in #1100.

-- Use ptaxsim as our "truth"
with tax as (
	select distinct substr(pin, 1, 10) as pin10,
		year,
		tax_code_num as truth
	from tax.pin
),
diffs as (
	select new.pin10,
		new.year,
		new.tax_code as new,
		old.tax_code as old,
		pins.truth as truth,
		case
			when new.tax_code != pins.truth
			and old.tax_code != pins.truth then 'both'
			-- Assume null tax codes are incorrect
			when (
				(
					new.tax_code != pins.truth
					or new.tax_code is null
				)
				and old.tax_code = pins.truth
			) then 'new'
			when (
				(
					old.tax_code != pins.truth
					or old.tax_code is null
				)
				and new.tax_code = pins.truth
			) then 'old'
		end as which_is_wrong
	from z_dev_wridgeway_spatial.parcel as new
		left join spatial.parcel as old on new.pin10 = old.pin10
		and new.year = old.year
		inner join tax as pins on new.pin10 = pins.pin10
		and new.year = pins.year
	where (new.tax_code != old.tax_code)
		or (
			new.tax_code is null
			and old.tax_code is not null
		)
		or (
			new.tax_code is not null
			and old.tax_code is null
		)
)
select which_is_wrong,
	count() as parcels
from diffs
group by which_is_wrong

WhichIsWrong	Parcels
old	530127
new	416
both	90

[jeancochrane]

As someone who never successfully figured out how to connect to the SQL server, I'm happy about this.