Skip to content

Upgrade gh-action-pypi-publish to v1.14.3 and fix builds - #55

Merged
jeancochrane merged 3 commits into
masterfrom
jeancochrane/upgrade-gh-action-pypi-publish-to-v1.14.3
Oct 22, 2026
Merged

jeancochrane merged 3 commits into
masterfrom
jeancochrane/upgrade-gh-action-pypi-publish-to-v1.14.3

Conversation

@jeancochrane

@jeancochrane jeancochrane commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

We need to update gh-action-pypi-publish in order to pull in the patch for GHSA-5xjx-3w67-w9x9. See the release notes: https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.14.3.

While we're here, we also need to make two small changes to fix builds:

  1. Add DyfanJones/noctua to the Remotes section of DESCRIPTION, since the package has been temporarily removed from CRAN
  2. Upgrade R pre-commit hooks, which are failing to install on R 4.6 (not currently affecting CI however, which is still running R 4.5)

I tried to test this change by running the workflow to upload the package to the PyPI test instance, but as you can see from the logs, the upload failed because the current package version already exists on the test PyPI instance. I thought about deleting the existing file to complete the test, but on reflection, it seems to me that this 400 is an indication that the gh-action-pypi-publish action is working as expected, so I think it's fine to move forward even without the workflow passing.

@jeancochrane jeancochrane changed the title Upgrade gh-action-pypi-publish to v1.14.3 Upgrade gh-action-pypi-publish to v1.14.3 and upgrade R pre-commit hooks Oct 21, 2026
@jeancochrane jeancochrane changed the title Upgrade gh-action-pypi-publish to v1.14.3 and upgrade R pre-commit hooks Upgrade gh-action-pypi-publish to v1.14.3 and fix builds Oct 21, 2026
Comment thread R/chars_funs.R
mapply(
function(x, y) {
if (is.na(x) | is.na(y)) {
if (is.na(x) || is.na(y)) {

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line was tripping the vector_logic_linter; see the pre-commit logs. I think it should be fine to switch to the scalar conditional operator || because mapply() should ensure that x and y are always scalar values, unless the user happens to erroneously pass a nested list of vectors for either the start_year or town arguments (in which case this conditional would just error out, I think).

@jeancochrane
jeancochrane marked this pull request as ready for review October 21, 2026 21:58
@jeancochrane
jeancochrane requested a review from a team as a code owner October 21, 2026 21:58
@jeancochrane
jeancochrane merged commit db57cd6 into master Oct 22, 2026
17 checks passed
@jeancochrane
jeancochrane deleted the jeancochrane/upgrade-gh-action-pypi-publish-to-v1.14.3 branch October 22, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants