Repository navigation
Upgrade gh-action-pypi-publish to v1.14.3 and fix builds - #55
Merged
jeancochrane merged 3 commits intoOct 22, 2026
Merged
Conversation
gh-action-pypi-publish to v1.14.3gh-action-pypi-publish to v1.14.3 and upgrade R pre-commit hooks
gh-action-pypi-publish to v1.14.3 and upgrade R pre-commit hooksgh-action-pypi-publish to v1.14.3 and fix builds
jeancochrane
commented
Oct 21, 2026
| mapply( | ||
| function(x, y) { | ||
| if (is.na(x) | is.na(y)) { | ||
| if (is.na(x) || is.na(y)) { |
Member
Author
There was a problem hiding this comment.
This line was tripping the vector_logic_linter; see the pre-commit logs. I think it should be fine to switch to the scalar conditional operator || because mapply() should ensure that x and y are always scalar values, unless the user happens to erroneously pass a nested list of vectors for either the start_year or town arguments (in which case this conditional would just error out, I think).
wrridgeway
approved these changes
Oct 22, 2026
jeancochrane
deleted the
jeancochrane/upgrade-gh-action-pypi-publish-to-v1.14.3
branch
October 22, 2026 15:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to update
gh-action-pypi-publishin order to pull in the patch for GHSA-5xjx-3w67-w9x9. See the release notes: https://github.com/pypa/gh-action-pypi-publish/releases/tag/v1.14.3.While we're here, we also need to make two small changes to fix builds:
DyfanJones/noctuato theRemotessection ofDESCRIPTION, since the package has been temporarily removed from CRANI tried to test this change by running the workflow to upload the package to the PyPI test instance, but as you can see from the logs, the upload failed because the current package version already exists on the test PyPI instance. I thought about deleting the existing file to complete the test, but on reflection, it seems to me that this 400 is an indication that the
gh-action-pypi-publishaction is working as expected, so I think it's fine to move forward even without the workflow passing.