Fix merge train stack collapse Postgres index length#619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The first failing deploy introduced a 64-character index name:
launchplane_merge_train_stack_collapse_plans_repository_base_idx. The live service creates missing schema at startup against Postgres, so the new image could fail before binding HTTP. The rollback image stays healthy, which is why the website remains usable.Validation
uv run --extra dev ruff check tests/test_postgres_store.py control_plane/storage/postgres.py control_plane/storage/migrations/versions/d289e3ab4012_add_merge_train_stack_collapse_plans.pyuv run python -m unittest tests.test_postgres_store.PostgresRecordStoreTests.test_postgres_metadata_index_names_fit_identifier_limit tests.test_postgres_store.PostgresRecordStoreTests.test_alembic_baseline_creates_schema_used_by_record_store tests.test_postgres_store.PostgresRecordStoreTests.test_merge_train_stack_collapse_plan_records_round_tripuv run python -m unittest tests.test_postgres_store tests.test_service tests.test_merge_train_stack_collapseuv run python -m unittest