cmake: update variables on reconfigure#239
Open
hannesbrandt wants to merge 2 commits intocburstedde:developfrom
Open
cmake: update variables on reconfigure#239hannesbrandt wants to merge 2 commits intocburstedde:developfrom
hannesbrandt wants to merge 2 commits intocburstedde:developfrom
Conversation
Owner
|
Thanks! This seems to be unrelated, but are you able to have the CI run through? |
Collaborator
Author
|
I've added some tests that were not yet included in the CMakeLists.txt, see #238. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update variables on reconfigure
Proposed changes:
Enabling MPI in cmake and then disabling it in a later reconfiguration causes an issue. While SC_ENABLE_MPI is updated correctly, other MPI-related variables like SC_ENABLE_MPIIO remain true, which causes errors during the build step.
There already is an if-clause in
cmake/config.cmakethat checks if SC_ENABLE_MPI was changed and updates the other MPI-related variables as desired. The clause is entered, if SC_ENABLE_MPI is different from its previous value CACHED_SC_ENABLE_MPI and updates CACHED_SC_ENABLE_MPI inside.The update of CACHED_SC_ENABLE_MPI uses the set-function (https://cmake.org/cmake/help/latest/command/set.html). According to its documentation, it does not necessarily overwrite the value of exisiting cache entries when the FORCE option is not enabled.
This PR adds FORCE to the set command, so that the if-clause will be activated as intended.