Skip to content

fix(isEmpty): Ignore empty strings on list iteration.#7

Merged
cbroglie merged 1 commit into
cbroglie:masterfrom
epek:master
Jun 29, 2016
Merged

fix(isEmpty): Ignore empty strings on list iteration.#7
cbroglie merged 1 commit into
cbroglie:masterfrom
epek:master

Conversation

@themihai
Copy link
Copy Markdown

@themihai themihai commented Jun 7, 2016

Initially submitted to hoisie#37

@cbroglie
Copy link
Copy Markdown
Owner

cbroglie commented Jun 7, 2016

Thanks @themihai, could you include a test case which demonstrates the behavior change?

@themihai
Copy link
Copy Markdown
Author

themihai commented Jun 7, 2016

As this is part of the spec I thought it's already covered by the mustache compliance tests suite. Let me know if it's not the case.

@cbroglie
Copy link
Copy Markdown
Owner

cbroglie commented Jun 8, 2016

If there is a spec test for this then it's currently one of the disabled ones (see https://github.com/cbroglie/mustache/blob/master/spec_test.go#L12). Enabling a spec test which was previously failing but is now passing with your change would be even better than a new standalone test.

@vvakame
Copy link
Copy Markdown

vvakame commented Jun 29, 2016

any update?
I want to make same changes. but I found this PR. I need this changes.

@cbroglie cbroglie merged commit 74a96fe into cbroglie:master Jun 29, 2016
cbroglie pushed a commit that referenced this pull request Jun 29, 2016
@cbroglie
Copy link
Copy Markdown
Owner

cbroglie commented Jun 29, 2016

I wrote a test for this in 214307b which confirms the behavior change. I looked through https://github.com/mustache/spec/blob/master/specs/sections.yml but didn't see an explicit test case. Thanks for the fix @themihai.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants