fix(isEmpty): Ignore empty strings on list iteration.#7
Conversation
|
Thanks @themihai, could you include a test case which demonstrates the behavior change? |
|
As this is part of the spec I thought it's already covered by the mustache compliance tests suite. Let me know if it's not the case. |
|
If there is a spec test for this then it's currently one of the disabled ones (see https://github.com/cbroglie/mustache/blob/master/spec_test.go#L12). Enabling a spec test which was previously failing but is now passing with your change would be even better than a new standalone test. |
|
any update? |
|
I wrote a test for this in 214307b which confirms the behavior change. I looked through https://github.com/mustache/spec/blob/master/specs/sections.yml but didn't see an explicit test case. Thanks for the fix @themihai. |
Initially submitted to hoisie#37