Fix confirmation token retry loop#35
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
confirmation_tokenas an optional top-level parameter on router schemas so MCP clients can resubmit gated actions.Root Cause
Gated actions read
confirmation_tokenfrom the top-level tool arguments, but the parameter was not present in the advertised schema. Some MCP clients dropped or misplaced the token on retry, causing the confirmation flow to issue a fresh token repeatedly.Validation
./vendor/bin/pest tests/Feature/ConfirmationActionsConfigTest.php tests/Unit/Auth/ConfirmationTokenManagerTest.php tests/Feature/McpJsonSchemaValidationTest.php./vendor/bin/pint --test src/Mcp/Tools/BaseRouter.php src/Mcp/Tools/Concerns/RequiresConfirmation.php src/Auth/ConfirmationTokenManager.php tests/Unit/Auth/ConfirmationTokenManagerTest.php tests/Feature/McpJsonSchemaValidationTest.php tests/Feature/ConfirmationActionsConfigTest.php./vendor/bin/phpstan analyse src/Auth/ConfirmationTokenManager.php src/Mcp/Tools/BaseRouter.php src/Mcp/Tools/Concerns/RequiresConfirmation.phpFixes #34.