Skip to content

Fix health readiness semantics#9

Merged
sylvesterdamgaard merged 1 commit into
mainfrom
fix-health-readiness
Jun 29, 2026
Merged

Fix health readiness semantics#9
sylvesterdamgaard merged 1 commit into
mainfrom
fix-health-readiness

Conversation

@sylvesterdamgaard

Copy link
Copy Markdown
Contributor

What changed

  • Run the first health check immediately after initial_delay instead of waiting for the first full period.
  • Mark supervisor readiness only after a real successful probe via LastCheckSucceeded.
  • Feed actual health snapshots into the file-based readiness manager.
  • Start the readiness monitor from serve and remove the readiness file during shutdown.
  • Add focused tests for immediate first checks and readiness requiring a successful probe.

Why

Dependencies and Kubernetes readiness could be delayed by initial_delay + period, and a transient failed readiness probe could still mark a dependency ready because liveness stayed optimistic until the failure threshold.

Validation

  • git diff --check
  • go test ./internal/process could not be run locally because go is not installed in this environment.

@sylvesterdamgaard sylvesterdamgaard marked this pull request as ready for review June 29, 2026 06:55
@sylvesterdamgaard sylvesterdamgaard merged commit 40ff473 into main Jun 29, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant