fix(nrPDSCHDMRS): gate 8/9-symbol additional DMRS on DMRSAdditionalPo… - #84
Open
ThereWasAYang wants to merge 2 commits into
Open
fix(nrPDSCHDMRS): gate 8/9-symbol additional DMRS on DMRSAdditionalPo…#84ThereWasAYang wants to merge 2 commits into
ThereWasAYang wants to merge 2 commits into
Conversation
…sition PDSCHDMRSSyms() appended an extra DMRS at symbol 7 for any 8- or 9-symbol PDSCH allocation, regardless of DMRSAdditionalPosition. When DMRSAdditionalPosition == 0 the type A single-symbol DMRS must contain only the front-loaded symbol l0, but the function returned two symbols. All other duration branches (10/11, 12, 13/14) already gate the additional DMRS on add_pos; the [8, 9] branch was missing that check. Add the `if add_pos >= 1` guard so the result matches 3GPP TS 38.211 Table 7.4.1.1.2-3. This also corrects the downstream APIs that rely on PDSCHDMRSSyms: nrPDSCHDMRSIndices, nrPDSCHDMRS, nrPDSCHIndices and nrPDSCHPTRS.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #83
PDSCHDMRSSyms() appended an extra DMRS at symbol 7 for any 8- or 9-symbol PDSCH allocation, regardless of DMRSAdditionalPosition. When DMRSAdditionalPosition == 0 the type A single-symbol DMRS must contain only the front-loaded symbol l0, but the function returned two symbols.
All other duration branches (10/11, 12, 13/14) already gate the additional DMRS on add_pos; the [8, 9] branch was missing that check. Add the
if add_pos >= 1guard so the result matches 3GPP TS 38.211 Table 7.4.1.1.2-3.This also corrects the downstream APIs that rely on PDSCHDMRSSyms: nrPDSCHDMRSIndices, nrPDSCHDMRS, nrPDSCHIndices and nrPDSCHPTRS.