Skip to content

Update nodes.json - #304

Closed
Nephwren wants to merge 0 commit into
catalystctl:mainfrom
Nephwren:main
Closed

Nephwren wants to merge 0 commit into
catalystctl:mainfrom
Nephwren:main

Conversation

@Nephwren

Copy link
Copy Markdown

Corrected translation error.

@pullfrog pullfrog Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ No critical issues — the fix is correct; two sibling strings share the same defect.

Reviewed changes

  • Corrected English SFTP port label — en/nodes.json changes "sftpEnabledPort": "Enabled :{{port}}" to "Enabled: {{port}}", removing a French-style space before the colon that was wrong in English. Rendered by t('agent.sftpEnabledPort', { port }) in catalyst-frontend/src/components/nodes/AgentControlPanel.tsx:261.

ℹ️ The French-style space-before-colon survives in two sibling strings

The same defect this PR fixes — an English/Chinese string copying the French typographic convention of a space before the colon — still appears in two other catalog entries.

  • catalyst-frontend/src/i18n/locales/zh-CN/nodes.json:69 — the Chinese translation of the exact key this PR touches, "sftpEnabledPort": "已启用 :{{port}}", keeps the halfwidth colon with a leading space. Every other zh-CN entry uses the fullwidth : with no surrounding space (e.g. zh-CN/nodes.json:47 "修改时间:{{time}}"), so this one is the outlier.
  • catalyst-frontend/src/i18n/locales/en/server-tabs.json:942 — "hour": "Runs hourly at minute :{{minute}}" should read at minute {{minute}}; the colon is a French artifact (the fr catalog at fr/server-tabs.json:980 legitimately uses à la minute :{{minute}}).

Both are cosmetic and out of scope for this PR; sweeping them in the same pass keeps the catalogs consistent.

Technical details
# French colon-spacing leaking into non-French catalogs

## Affected sites
- `catalyst-frontend/src/i18n/locales/zh-CN/nodes.json:69` — `已启用 :{{port}}`; should use `:` with no leading space to match the rest of the zh-CN catalog.
- `catalyst-frontend/src/i18n/locales/en/server-tabs.json:942` — `Runs hourly at minute :{{minute}}`; should be `Runs hourly at minute {{minute}}`.

## Required outcome
- English and Chinese strings no longer carry a space before the colon. French (`fr`) keeps its space-before-colon, which is correct there.

## Notes
- Changing a value (not a key) is extractor-safe: `i18n:extract` preserves existing `en` values and key order, so no re-extraction is required for the current change.

Pullfrog  | Fix it ➔ | View workflow run | Using umans-deepseek-v4.1-flash | 𝕏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant