Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
ℹ️ No critical issues — the fix is correct; two sibling strings share the same defect.
Reviewed changes
- Corrected English SFTP port label —
en/nodes.jsonchanges"sftpEnabledPort": "Enabled :{{port}}"to"Enabled: {{port}}", removing a French-style space before the colon that was wrong in English. Rendered byt('agent.sftpEnabledPort', { port })incatalyst-frontend/src/components/nodes/AgentControlPanel.tsx:261.
ℹ️ The French-style space-before-colon survives in two sibling strings
The same defect this PR fixes — an English/Chinese string copying the French typographic convention of a space before the colon — still appears in two other catalog entries.
catalyst-frontend/src/i18n/locales/zh-CN/nodes.json:69— the Chinese translation of the exact key this PR touches,"sftpEnabledPort": "已启用 :{{port}}", keeps the halfwidth colon with a leading space. Every other zh-CN entry uses the fullwidth:with no surrounding space (e.g.zh-CN/nodes.json:47"修改时间:{{time}}"), so this one is the outlier.catalyst-frontend/src/i18n/locales/en/server-tabs.json:942—"hour": "Runs hourly at minute :{{minute}}"should readat minute {{minute}}; the colon is a French artifact (the fr catalog atfr/server-tabs.json:980legitimately usesà la minute :{{minute}}).
Both are cosmetic and out of scope for this PR; sweeping them in the same pass keeps the catalogs consistent.
Technical details
# French colon-spacing leaking into non-French catalogs
## Affected sites
- `catalyst-frontend/src/i18n/locales/zh-CN/nodes.json:69` — `已启用 :{{port}}`; should use `:` with no leading space to match the rest of the zh-CN catalog.
- `catalyst-frontend/src/i18n/locales/en/server-tabs.json:942` — `Runs hourly at minute :{{minute}}`; should be `Runs hourly at minute {{minute}}`.
## Required outcome
- English and Chinese strings no longer carry a space before the colon. French (`fr`) keeps its space-before-colon, which is correct there.
## Notes
- Changing a value (not a key) is extractor-safe: `i18n:extract` preserves existing `en` values and key order, so no re-extraction is required for the current change.
umans-deepseek-v4.1-flash | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Corrected translation error.