remove unused attributes#26
Merged
Merged
Conversation
jay-oswald
force-pushed
the
remove-unused-actionurl
branch
from
dbdc969 to
27f2e86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
$this->actionurlfrom the forms, its throwing an error in php 8.3 because you can no longer create parameters dynamically.Both these classes extend
moodleformclass, which ofcourse dosen't have actionurl paramater, or we wouldn't get this error in the first place. The only time action is ever passed through it on__contruct, and is never stored anywhere just used, and passed through to$this->_formwhich uses the classMoodleQuickFormMoodleQuickFormalso never stores action as a variable either, it is just saved to$this-> _attributesarray, so it is not possible with the code I can see that$this->actionurlis doing anything.It is possible on older versions of Moodle it has done something, though looking at blame on the relevant classes, this is very very old moodle code so I doubt it. I think it was just an attempt to set action url initially and its stuck around.
We do pass through action as a paramater to the constructor properly anyway, so it does work the proper method