[#146] Add observee visibility#147
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #146 by ensuring the selected observee’s identity is visible while grading/observing, including on pages where it was previously missing, and does so using Moodle’s configured identity-field visibility rules.
Changes:
- Show the observee’s name (via
fullname()) near the top ofsession.phpwhile marking. - Show the observee’s name (via
fullname()) near the top ofsessionsummary.php. - Optionally display secondary identity fields (email/username) based on
\core_user\fields::get_identity_fields(...).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| session.php | Adds an observee identity header (name + permitted identity fields) on the marking page. |
| sessionsummary.php | Adds an observee identity header (name + permitted identity fields) on the session summary page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Hey @gbarat87 , can you please review this one for me when you have a moment. |
gbarat87
reviewed
Apr 20, 2026
Contributor
|
Hi, I have tested locally and it works as expected. Guillaume |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge request fixes issue (#146) where the identity of the observee cannot be seen from multiple pages. This implementation also respects Moodle privacy settings.
Screenshots: