Makes block more self-contained and fixes some phpcs issues#11
Open
parkeyparker wants to merge 1 commit into
Open
Makes block more self-contained and fixes some phpcs issues#11parkeyparker wants to merge 1 commit into
parkeyparker wants to merge 1 commit into
Conversation
Block no longer redirects to /auth/enrolkey/view.php and instead uses notifications to display enrolment changes on the dashboard page itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Various changes to try and make the block more self-contained:
/auth/enrolkey/view.phpand instead uses notifications to display enrolment changes on the dashboard page itselfauth_enrolkeyis disabled and block is added to the dashboard - avoids confusion when adding it and it disappears when edit mode is offThis has only been tested with Moodle 4.1 currently.
Unable to replicate #10.