Add Mac Catalyst app support - #210
Merged
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
There was a problem hiding this comment.
🟡 Changes recommended
Address the two README review comments before approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds Mac Catalyst support for Holmdel while excluding iOS-only companions and providing Catalyst-safe Live Activity behavior.
Changes:
- Enables Catalyst builds and filters widget/watch products.
- Adds Catalyst no-op Live Activity implementations.
- Updates documentation and changelog.
File summaries
| File | Summary |
|---|---|
README.md |
Documents Catalyst support. Nits: Correct the dependency/platform description (2 votes) and add the required DECISIONS.md entry (1 vote). |
Packages/LiveActivity/Sources/NowPlayingActivityKit/NowPlayingActivityCoordinator.swift |
Adds Catalyst no-op behavior. |
Packages/LiveActivity/Sources/NowPlayingActivityCore/NowPlayingActivityAttributes.swift |
Excludes ActivityKit types on Catalyst. |
HolmdelApp/Holmdel.xcodeproj/project.pbxproj |
Enables Catalyst and filters iOS-only embedded targets. |
CHANGELOG.md |
Adds the Mac support entry. |
Review details
Suppressed comments (1)
README.md:4
- This adds a new platform and changes the shared dependency/availability architecture, but
CONTRIBUTING.md:90-91requires significant decisions to be recorded inDECISIONS.mdwith their rationale. Please add a dated entry covering the Catalyst no-op and the iOS-only widget/watch packaging filters so this design is not lost or accidentally reverted.
Holmdel is a SwiftUI internet-radio client for iOS and iPadOS 26+, with a Mac Catalyst build and
companion apps for watchOS and tvOS, built on **ShoutKit** — this repo's MIT-licensed radio SDK
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
114
to
116
| iOS and Mac Catalyst only, linked by the app target alone: AudioStreaming pulls the ogg/vorbis xcframeworks, | ||
| which have no watchOS slice, and SwiftPM fetches binary artifacts regardless of platform | ||
| conditions. The watch app supplies its own `AVPlayer`-backed engine. |
Contributor
Author
|
@copilot Fix the code for all comments in this review thread. When a review comment includes a suggested change, apply the suggestion exactly. Do not make changes beyond what is described in the linked review thread. |
Co-authored-by: KevinTCoughlin <706967+KevinTCoughlin@users.noreply.github.com>
Contributor
Addressed in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
xcodebuildDebug build forplatform=macOS,variant=Mac CatalystxcodebuildRelease build forplatform=macOS,variant=Mac Catalyst