fix(FCM.Error): implement recursive parsing for handling multiple ele… - #1
Draft
caruspi wants to merge 4 commits into
Draft
fix(FCM.Error): implement recursive parsing for handling multiple ele…#1caruspi wants to merge 4 commits into
caruspi wants to merge 4 commits into
Conversation
…ments in "details" Refactored the `parse/1` function to use recursion for correctly handling cases where the "details" list contains multiple elements, and falling back to the "status" field when necessary.
caruspi
force-pushed
the
fix/fcm-error-handling
branch
from
February 25, 2025 16:53
7aca252 to
c19f5b0
Compare
* feat: replace kadabra with mint * feat: remove kadabra from mix.exs * feat: make ADM workers use mint * refactor: various cleanup * test: increase test coverage * refactor: more cleanup * refactor: ADM.Token and other refactoring * docs: update CHANGELOG * fix: resolve comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ments in "details"
Refactored the
parse/1function to use recursion for correctly handling cases where the "details" list contains multiple elements, and falling back to the "status" field when necessary.