Added denominators to the PE counts on RT#307
Open
Jack-p87 wants to merge 1 commit into
Open
Conversation
and seasons on rocket tracker.
carpetsage
reviewed
Apr 17, 2025
| import { useSectionVisibility } from 'ui/composables/section_visibility'; | ||
| import { reportLegendaries, reportMissionData } from '@/lib'; | ||
| import { REPORT_LEGENDARIES, REPORT_MISSIONDATA } from '@/events'; | ||
| import { getUserContractList, contractSeasonList, } from '@/../../past-contracts/src/contracts'; |
Owner
There was a problem hiding this comment.
All projects under wasmegg are self contained and shouldn't link to each other. If there's code in past-contracts that would be useful in rockets tracker it should move to /lib and then both projects should reference that
carpetsage
reviewed
Apr 17, 2025
| /* eslint-disable vue/no-setup-props-destructure */ | ||
| async setup({ playerId, eventBus }) { | ||
| const data = await requestFirstContact(playerId); | ||
| const contractsArchive = await requestContractsArchive(playerId); |
Owner
There was a problem hiding this comment.
I don't think this api request should be required? Generally try to avoid api requests because they're slow and I've had rate limiting issues.
As far as I recall the only reason to hit the contracts archive api is if you need score info from past contracts. If you're just trying to see which contracts have the PE goal achieved the contract history in the backup which is already being pulled should be good enough
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added denominators to the contract PE and seasonal PE counts on rocket-tracker. Imported the logic from past-contracts.