Use CoinGecko for KuCoin futures top movers#1012
Open
carkod wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
CoinGecko.get_kucoin_futures_tickers()which callsGET /derivatives/exchanges/kumex?include_tickers=unexpiredand returns per-contract tickers.CoinGeckoclient intoMarketDominationControllerand replaced the previous Binance/spot-based ranking with filtering for USDT perpetual KuCoin futures and sorting byh24_percentage_change.api/tests/test_charts.pyto monkeypatchCoinGecko.get_kucoin_futures_tickersand assert the top-gainers/top-losers payloads, and added a controller-level test intest_market_domination_controller.pyto exercise filtering and ordering logic.Testing
make formatand fixes were applied with no issues.env ... make test(test environment variables provided) and the full test run completed successfully with all tests passing (120 passed).Codex Task