Skip to content

Remove min-height from host-mode stack-item container #4365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
burieberry merged 1 commit into from
Apr 9, 2026
Merged

Remove min-height from host-mode stack-item container #4365

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/boxel-ui/addon/src/components/card-container/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,14 +49,15 @@ const CardContainer: TemplateOnlyComponent<Signature> = <template>
:global(.boxel-card-container) {
position: relative;
background-color: var(--background, var(--boxel-light));
border-radius: var(--radius, var(--boxel-border-radius));
border-radius: var(--_boxel-radius);
color: var(--foreground, var(--boxel-dark));
transition:
max-width var(--boxel-transition),
box-shadow var(--boxel-transition);
height: 100%;
width: 100%;
overflow: hidden;
z-index: 0;
}
:global(.boxel-card-container--boundaries:not(.hide-boundaries)) {
box-shadow: 0 0 0 1px var(--border, var(--boxel-border-color));
Expand Down
10 changes: 9 additions & 1 deletion packages/boxel-ui/addon/src/components/context-button/index.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,14 +14,16 @@ export type ContextButtonVariant =
| 'ghost'
| 'destructive'
| 'highlight-icon'
| 'destructive-icon'; // 'highlight' is default
| 'destructive-icon'
| 'primary-dark'; // 'highlight' is default

export const contextButtonVariants: ContextButtonVariant[] = [
'highlight',
'highlight-icon',
'ghost',
'destructive',
'destructive-icon',
'primary-dark',
];

export type ContextButtonIcon =
Expand Down Expand Up @@ -140,6 +142,12 @@ const DropdownButton: TemplateOnlyComponent<Signature> = <template>
background-color: var(--destructive, var(--boxel-danger));
}

.boxel-context-button--primary-dark {
color: var(--primary, var(--boxel-highlight));
background-color: var(--primary-foreground, var(--boxel-700));
border: 1px solid var(--boxel-light-hover-35);
}

.boxel-context-button:disabled,
.boxel-context-button[disabled] {
color: var(--boxel-400);
Expand Down
1 change: 1 addition & 0 deletions packages/boxel-ui/addon/src/styles/variables.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@
--boxel-dark: #000;
--boxel-dark-hover: rgba(0, 0, 0, 0.1);
--boxel-darker-hover: rgba(0, 0, 0, 0.5);
--boxel-light-hover-35: rgba(255, 255, 255, 0.35);

--boxel-highlight: var(--boxel-teal);
--boxel-highlight-hover: var(--boxel-dark-teal);
Expand Down
22 changes: 10 additions & 12 deletions packages/host/app/components/host-mode/stack-item.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ export default class HostModeStackItem extends Component<Signature> {
<ContextButton
@icon='close'
@label='close'
@variant='primary-dark'
{{on 'click' this.handleClose}}
data-test-host-stack-item-close-button
/>
Expand Down Expand Up @@ -211,17 +212,11 @@ export default class HostModeStackItem extends Component<Signature> {
position: absolute;
width: 89%;
height: inherit;
padding-top: var(--boxel-sp-xxl);
padding-top: var(--boxel-sp-2xl);
z-index: 0;
pointer-events: none;
}
@media screen {
.host-mode-stack-item {
min-height: 80cqh;
}
}
.host-mode-stack-item:not(.buried) {
padding-bottom: var(--boxel-sp-xxl);
}
Expand Down Expand Up @@ -261,7 +256,7 @@ export default class HostModeStackItem extends Component<Signature> {
.stack-item-card {
height: 100%;
border-radius: var(--boxel-border-radius-xl);
border-radius: var(--boxel-border-radius-2xl);
box-shadow: var(--boxel-deep-box-shadow);
pointer-events: auto;
overflow: hidden;
Expand All @@ -282,18 +277,21 @@ export default class HostModeStackItem extends Component<Signature> {
right: var(--boxel-sp-xs);
z-index: 1;
}
.close-button-container :deep(.boxel-context-button:not(:hover)) {
background-color: var(--boxel-100);
}
.close-button-container :deep(.boxel-context-button) {
box-shadow: var(--boxel-box-shadow);
}
.close-button-container :deep(.boxel-context-button:hover) {
box-shadow: var(--boxel-box-shadow-hover);
}
.host-mode-stack-item-card {
border-radius: 0;
border-radius: inherit;
box-shadow: none;
z-index: 0;
}
.host-mode-stack-item-card > :deep(.boxel-card-container) {
border-radius: inherit;
}
@media print {
.host-mode-stack-item {
Expand Down
1 change: 0 additions & 1 deletion packages/host/app/components/host-mode/stack.gts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export default class HostModeStack extends Component<Signature> {
/* .inner will handle overflow in host mode stack */
.host-mode-stack :deep(.host-mode-card, .card) {
overflow: hidden;
min-height: 80cqh;
}
}
Expand Down
Loading