Update phase-2 plan and README for boxel-cli integration and issue-driven loop#4353
Open
Update phase-2 plan and README for boxel-cli integration and issue-driven loop#4353
Conversation
…n loop, and validation phase Phase-2 plan updates: - Add architectural principle: boxel-cli owns entire Boxel API surface - Add realm-operations.ts migration table (20 functions → boxel-cli) - Add boxel-cli full auth lifecycle (CS-10642) replacing --jwt approach - Add tool delegation section (CS-10670): boxel-cli publishes tool definitions - Add MCP server as future evolution for tool discovery - Add skill alignment section (CS-10613): dedup, consistent homes, boxel-api skill - Add schema refinement: Ticket → Issue rename, trim unused fields, add blockedBy/order - Add validation phase after every inner-loop iteration (parse, lint, evaluate, instantiate, test) - Rewrite orchestrator as two-level loop (outer: issues, inner: iterations with validation) - Scope federated search to /_federated-search only - Add Linear project reference for "Incorporate Boxel CLI to Monorepo" - Reference all new tickets (CS-10666–CS-10677) README updates: - Rewrite intro to describe the four-phase factory flow - Add realm roles and artifact structure - Simplify prerequisites - Add "Running the Factory" section with full E2E command and expected output - Remove stale Commands section Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1395e995e8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…alidation failure - README: Move credentials to pre-exported env vars with read -s for password instead of inlining secrets in the command example - Phase-2 plan: Break inner loop after creating fix issues so the outer loop picks them up, preventing duplicate fix issue generation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the software-factory documentation to reflect the Phase 2 direction (boxel-cli integration, issue-driven scheduling, and a per-iteration validation pipeline) and to refresh the package README with current end-to-end usage guidance.
Changes:
- Rewrites
docs/phase-2-plan.mdto describe an issue-driven outer/inner loop with an orchestrator-owned validation phase and boxel-cli integration boundaries. - Rewrites
README.mdto explain the factory’s phases, target-realm artifact layout, prerequisites, and an examplepnpm factory:gorun with expected output.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/software-factory/README.md | Refreshes overview, prerequisites, and “Running the Factory” instructions plus expected CLI/UI outputs. |
| packages/software-factory/docs/phase-2-plan.md | Updates Phase 2 plan with validation-after-each-iteration design and expanded boxel-cli integration/delegation architecture notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- README: Use "ticket" consistently (Phase 1 terminology) - Phase-2 plan: Use enum priorities (high/medium/low) instead of numeric - Phase-2 plan: Validation failures iterate in inner loop (feed back as context) instead of creating fix issues. Agent can create issues via tool calls if it decides to. - Phase-2 plan: Fix inconsistency about who runs tests — orchestrator owns validation, delegates implementation to agent - Phase-2 plan: Update Core Idea to include validation step - Phase-2 plan: Update orchestrator pseudocode to match Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase-2 plan changes
getToolDefinitions()boxel-apiskillblockedBy/order/_federated-searchonlyREADME changes
mise run dev-all+ credentials + OpenRouter keyTest plan
pnpm --filter software-factory lintpasses (js, types, format)🤖 Generated with Claude Code