Capture .test.gts in live-test by tintinthong · Pull Request #4342 · cardstack/boxel

tintinthong · 2026-04-07T09:40:11Z

No description provided.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7c588a0239

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-07T09:46:29Z

packages/host/scripts/live-test-wait-for-servers.sh

+if [ -n "$1" ]; then
+  REALM_URL="$1"


Use REALM_URL env var when building readiness targets

The readiness selection only keys off $1, but the documented invocation is REALM_URL=... pnpm test:live. In that case, line 18 still forwards REALM_URL to the test runner, while this branch falls back to catalog readiness URLs, so live tests can begin before the requested realm is up and fail when _mtimes is fetched from that realm. Derive readiness URLs from the effective realm value (env var or arg) so wait-on tracks the same realm the tests will hit.

Useful? React with 👍 / 👎.

github-actions · 2026-04-07T09:54:16Z

Preview deployments

github-actions · 2026-04-07T10:05:11Z

Host Test Results

2 185 tests +10 2 170 ✅ +10 2h 20m 50s ⏱️ - 1m 14s
1 suites ± 0 15 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit a71063b. ± Comparison against base commit 42fecf7.

This pull request removes 1 and adds 11 tests. Note that renamed tests count towards both.

Chrome ‑ Integration | operator-mode | card catalog > recents section: filters cards by type for "Find Instances" search

Chrome ‑ Integration | RichMarkdownField: cardReferenceUrls computes resolved URLs from markdown content
Chrome ‑ Integration | RichMarkdownField: cardReferenceUrls returns empty array for content without references
Chrome ‑ Integration | RichMarkdownField: edit template renders textarea for content
Chrome ‑ Integration | RichMarkdownField: linkedCards query resolves referenced cards from the realm
Chrome ‑ Integration | RichMarkdownField: renders block ::card references as BFM elements
Chrome ‑ Integration | RichMarkdownField: renders footnotes
Chrome ‑ Integration | RichMarkdownField: renders inline :card references as BFM elements
Chrome ‑ Integration | RichMarkdownField: renders markdown as HTML
Chrome ‑ Integration | RichMarkdownField: renders with null content without error
Chrome ‑ Integration | operator-mode | ui: search sheet expands to results when realm filter is changed
…

♻️ This comment has been updated with latest results.

github-actions · 2026-04-07T10:10:20Z

Realm Server Test Results

1 files ±0 1 suites ±0 13m 31s ⏱️ -19s
836 tests ±0 836 ✅ ±0 0 💤 ±0 0 ❌ ±0
907 runs ±0 907 ✅ ±0 0 💤 ±0 0 ❌ ±0

Results for commit a71063b. ± Comparison against base commit 42fecf7.

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

This PR updates the host “live-test” runner to focus discovery on realm-hosted *.test.gts modules, adds better failure handling when _mtimes isn’t accessible, and introduces configuration/docs to make running live tests against different realms easier.

Changes:

Narrow test module discovery in live-test.js to *.test.gts and add an explicit non-2xx _mtimes error.
Allow testem-live.js to target a realm via REALM_URL (and lay groundwork for multiple pages).
Add live-test documentation and update virtual-network shims to provide non-crashing fallbacks for test-only imports.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
packages/host/tests/live-test.js	Changes how realm test modules are discovered/loaded; adds `_mtimes` HTTP error handling.
packages/host/testem-live.js	Makes the live test page configurable via `REALM_URL` and supports generating multiple test pages.
packages/host/scripts/live-test-wait-for-servers.sh	Adds conditional waiting logic intended to support a targeted realm.
packages/host/docs/live-tests.md	Introduces documentation for running card-based live tests in browser/script mode.
packages/host/app/lib/externals.ts	Adjusts shims for test-only imports so realm cards co-locating test imports won’t crash outside test runs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

packages/host/tests/live-test.js

Copilot · 2026-04-07T13:27:06Z

packages/host/scripts/live-test-wait-for-servers.sh

-READY_URLS="$BASE_REALM_READY|$CATALOG_REALM_READY|$SYNAPSE_URL|$SMTP_4_DEV_URL"
+if [ -n "$1" ]; then
+  REALM_URL="$1"
+  REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')


The readiness-check URL construction is fragile: it only strips http:// (so https://... becomes invalid), and it concatenates ${REALM_HOST}${READY_PATH} without ensuring a trailing / on the realm URL. If a user passes http://localhost:4201/catalog (no trailing slash), this produces .../catalog_readiness-check... and wait-on will never succeed. Consider parsing with a URL-aware approach (or at least handle both http/https and normalize to a trailing / before appending the readiness path).

Suggested change

REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')

REALM_HOST="$REALM_URL"

case "$REALM_HOST" in

http://*) REALM_HOST="${REALM_HOST#http://}" ;;

https://*) REALM_HOST="${REALM_HOST#https://}" ;;

esac

case "$REALM_HOST" in

*/) ;;

*) REALM_HOST="${REALM_HOST}/" ;;

esac

Valid comment, we can improve this

packages/host/docs/live-tests.md

packages/host/testem-live.js

Copilot · 2026-04-07T13:27:07Z

packages/host/scripts/live-test-wait-for-servers.sh

+if [ -n "$1" ]; then
+  REALM_URL="$1"
+  REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')
+  REALM_READY="http-get://${REALM_HOST}${READY_PATH}"
+  READY_URLS="$BASE_REALM_READY|$REALM_READY|$SYNAPSE_URL|$SMTP_4_DEV_URL"
+else
+  CATALOG_REALM_READY="http-get://localhost:4201/catalog/${READY_PATH}"
+  READY_URLS="$BASE_REALM_READY|$CATALOG_REALM_READY|$SYNAPSE_URL|$SMTP_4_DEV_URL"
+fi


pnpm test:live supports targeting a realm via the REALM_URL environment variable (as used by testem-live.js), but this script only switches readiness-check URLs based on $1. Running REALM_URL=http://localhost:4201/experiments/ pnpm test:live will still wait on the catalog realm (not the experiments realm), which can make the live test run flaky if the targeted realm isn’t ready yet. Consider using ${REALM_URL:-$1} (or similar) to drive both the wait-on URLs and the env var passed to testem.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

richardhjtan · 2026-04-08T08:26:49Z

packages/host/scripts/live-test-wait-for-servers.sh

-READY_URLS="$BASE_REALM_READY|$CATALOG_REALM_READY|$SYNAPSE_URL|$SMTP_4_DEV_URL"
+if [ -n "$1" ]; then
+  REALM_URL="$1"
+  REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')


Valid comment, we can improve this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5d193773d5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-04-08T08:29:18Z

packages/host/scripts/live-test-wait-for-servers.sh

+  REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')
+  REALM_READY="http-get://${REALM_HOST}${READY_PATH}"


Preserve scheme when deriving readiness URL

The custom-realm branch strips only http:// before constructing REALM_READY, so passing an HTTPS realm (for example https://...) produces a malformed wait target like http-get://https://... and start-server-and-test never observes readiness. This blocks pnpm test:live for any non-HTTP realm URL even though the new code path is meant to support arbitrary realm inputs.

Useful? React with 👍 / 👎.

tintinthong marked this pull request as draft April 7, 2026 09:40

chatgpt-codex-connector bot reviewed Apr 7, 2026

View reviewed changes

tintinthong changed the title ~~Remove colocated module test~~ Refine running of live test script Apr 7, 2026

tintinthong changed the title ~~Refine running of live test script~~ Capture .test.gts in live-test Apr 7, 2026

tintinthong requested a review from Copilot April 7, 2026 13:19

Copilot started reviewing on behalf of tintinthong April 7, 2026 13:20 View session

Copilot AI reviewed Apr 7, 2026

View reviewed changes

fix tests

5d19377

tintinthong force-pushed the remove-colocated-module-test branch from 7c588a0 to 5d19377 Compare April 8, 2026 01:46

tintinthong requested a review from richardhjtan April 8, 2026 08:19

tintinthong marked this pull request as ready for review April 8, 2026 08:19

Apply suggestions from code review

57fc0dc

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

richardhjtan approved these changes Apr 8, 2026

View reviewed changes

chatgpt-codex-connector bot reviewed Apr 8, 2026

View reviewed changes

apply copilot fixes

a71063b

tintinthong merged commit 6a2e5dc into main Apr 8, 2026
63 of 64 checks passed

-  REALM_HOST=$(echo "$REALM_URL" | sed 's|http://||')
+  REALM_HOST="$REALM_URL"
+  case "$REALM_HOST" in
+    http://*) REALM_HOST="${REALM_HOST#http://}" ;;
+    https://*) REALM_HOST="${REALM_HOST#https://}" ;;
+  esac
+  case "$REALM_HOST" in
+    */) ;;
+    *) REALM_HOST="${REALM_HOST}/" ;;
+  esac

		REALM_HOST=$(echo "$REALM_URL" \| sed 's\|http://\|\|')
		REALM_READY="http-get://${REALM_HOST}${READY_PATH}"

Conversation

tintinthong commented Apr 7, 2026

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 7, 2026

Preview deployments

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Host Test Results

Uh oh!

github-actions bot commented Apr 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Realm Server Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

richardhjtan Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 7, 2026

Choose a reason for hiding this comment

Uh oh!

richardhjtan Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot Apr 8, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Apr 7, 2026 •

edited

Loading

github-actions bot commented Apr 7, 2026 •

edited

Loading