Skip to content

Cs 10652/introduce the cardthumbnail inside cardinfofield#4341

Draft
lucaslyl wants to merge 4 commits intomainfrom
CS-10652/introduce-the-cardthumbnail-inside-cardinfofield
Draft

Cs 10652/introduce the cardthumbnail inside cardinfofield#4341
lucaslyl wants to merge 4 commits intomainfrom
CS-10652/introduce-the-cardthumbnail-inside-cardinfofield

Conversation

@lucaslyl
Copy link
Copy Markdown
Contributor

@lucaslyl lucaslyl commented Apr 7, 2026

linear: https://linear.app/cardstack/issue/CS-10652/introduce-the-cardthumbnail-inside-cardinfofield

Fix cyclic deps: consolidate NumberField, FileDef, ImageDef into card-api; add cardThumbnail to CardInfoField
NumberField, FileDef, and ImageDef were in separate modules that all imported from card-api. Adding cardThumbnail = linksTo(() => ImageDef) to CardInfoField would have created a circular import chain. Moving all
three into card-api breaks the cycle; the old files become re-export shims for backwards compatibility. (mirroring what theme.gts, text-area.gts did)

Remove MaybeBase64Field, use StringField for cardThumbnailURL
MaybeBase64Field was a StringField subclass whose only purpose was to display "(Base64 encoded value)" instead of raw data. Now that cardThumbnail (ImageDef) exists as the proper image field, the workaround
is no longer needed. Replace all usages with plain StringField and update test snapshots accordingly.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Preview deployments

lucaslyl added 2 commits April 7, 2026 17:15
…-api; add cardThumbnail to CardInfoField

NumberField, FileDef, and ImageDef were in separate modules that all
imported from card-api. Adding `cardThumbnail = linksTo(() => ImageDef)`
to CardInfoField would have created a circular import chain. Moving all
three into card-api breaks the cycle; the old files become re-export shims
for backwards compatibility.
MaybeBase64Field was a StringField subclass whose only purpose was to
display "(Base64 encoded value)" instead of raw data. Now that
cardThumbnail (ImageDef) exists as the proper image field, the workaround
is no longer needed. Replace all usages with plain StringField and update
test snapshots accordingly.
@lucaslyl lucaslyl force-pushed the CS-10652/introduce-the-cardthumbnail-inside-cardinfofield branch from 24941df to 5d71e37 Compare April 7, 2026 09:18
@cardstack cardstack deleted a comment from chatgpt-codex-connector bot Apr 7, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Host Test Results

    1 files  ±0      1 suites  ±0   2h 19m 10s ⏱️ + 2m 52s
2 090 tests  - 8  2 030 ✅  - 53  15 💤 ±0   0 ❌ ± 0  45 🔥 +45 
2 090 runs   - 8  1 985 ✅  - 98  15 💤 ±0  45 ❌ +45  45 🔥 +45 

For more details on these errors, see this check.

Results for commit f681244. ± Comparison against base commit 5a2946d.

This pull request removes 10 and adds 2 tests. Note that renamed tests count towards both.
Chrome ‑ Integration | Command | host command schema generation test > command schema generation: getInputJsonSchema for OpenCreatePRModalCommand
Chrome ‑ Integration | commands | open-create-pr-modal: dismissCreatePRModal clears the payload
Chrome ‑ Integration | commands | open-create-pr-modal: stores modal payload in operator mode state
Chrome ‑ Integration | commands | open-create-pr-modal: stores modal payload without listingName
Chrome ‑ Integration | components | create-pr-modal: cancel button dismisses the modal
Chrome ‑ Integration | components | create-pr-modal: does not show a separate realm field in modal
Chrome ‑ Integration | components | create-pr-modal: does not show change action when catalog chooser is unavailable
Chrome ‑ Integration | components | create-pr-modal: modal renders when payload is set
Chrome ‑ Integration | components | create-pr-modal: shows the listing pill in modal
Chrome ‑ Integration | components | create-pr-modal: submit shows success state
Chrome ‑ Integration | Command | host command schema generation test > command schema generation: getInputJsonSchema for CreateAndOpenSubmissionWorkflowCardCommand
Chrome ‑ Integration | Command | host command schema generation test > command schema generation: getInputJsonSchema for CreateSubmissionWorkflowCommand

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Realm Server Test Results

  1 files  ±0    1 suites  ±0   13m 15s ⏱️ -2s
834 tests ±0  826 ✅  - 8  0 💤 ±0  8 ❌ +8 
905 runs  ±0  897 ✅  - 8  0 💤 ±0  8 ❌ +8 

For more details on these failures, see this check.

Results for commit f681244. ± Comparison against base commit 5a2946d.

This pull request removes 8 and adds 8 tests. Note that renamed tests count towards both.
default ‑ extracts PR number from check_run event
default ‑ extracts PR number from check_suite event
default ‑ extracts PR number from pull_request event
default ‑ extracts realm from local Submission Card URL
default ‑ extracts realm from production Submission Card URL
default ‑ extracts realm from staging Submission Card URL
default ‑ returns null when no PR number found
default ‑ returns null when no Submission Card line exists
default ‑ extracts branch name from check_run event
default ‑ extracts branch name from check_suite event
default ‑ extracts branch name from pull_request event
default ‑ extracts realm from local Workflow Card URL
default ‑ extracts realm from production Workflow Card URL
default ‑ extracts realm from staging Workflow Card URL
default ‑ returns null when no Workflow Card line exists
default ‑ returns null when no branch name found

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant