Repository navigation
Conversation
Trinity tells each emitter which ball it is mounted on through ITr2AudParentBall. Emitters hold it weakly and the sightline pass hands it to destiny with the emitter's position, so destiny can skip that ball's own geometry. Deployables and walls no longer occlude their own emitters. IEveObstructionQuery2 replaces IEveObstructionQuery: Blue matches interfaces by name, so the new QuerySightlines signature needs a new name.
phevosccp
changed the title
ccp-zoetrope
approved these changes
Nov 2, 2026
ccp-zoetrope
left a comment
ccp-zoetrope
left a comment
Member
There was a problem hiding this comment.
I made a suggestion that I don't consider blocking but more of a nice to have if you agree.
| * @return False when there is no answer right now (no world loaded, mid-transition). It means "ask | ||
| * again", not "nothing is blocked": the caller keeps its previous results and retries. | ||
| */ | ||
| virtual bool QuerySightlines( const Vector3& source, const Vector3* targets, IRoot* const* targetParents, unsigned int targetCount, bool* outBlocked ) = 0; |
Member
There was a problem hiding this comment.
Since we're redefining the interface currently I think it would simplify things if both the position of the ball and it's owner travelled together in a struct or something. Something like
struct EveSightLineTarget
{
Vector3 position;
IRoot* parent;
}
Instead of having targets and targetParents as separate concepts.
From a readability point of view it makes it easier for me to reason about personally and will make it easier to not accidentally have the parent and position drift while keeping track of them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #22. Emitters on a deployable or wall were occluded by that object's own collision. Trinity now gives each emitter the ball it is mounted on through
ITr2AudParentBall(carbonengine/trinity#134).IEveObstructionQuery2replacesIEveObstructionQuery. Blue matches interfaces by name, so the newQuerySightlinessignature needs a new name. Destiny implements both, so destiny ships first.Depends on carbonengine/trinityaudioapi#11. The
carbon-trinityaudioapibump follows once the registry has the port.Testing