Skip to content

fix(invite): honor --role when re-inviting an existing member #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cvince merged 1 commit into from
Jun 9, 2026
Merged

fix(invite): honor --role when re-inviting an existing member #234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions src/commands/inviteCommand.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,10 +149,17 @@ export class InviteCommand {
let projectId: string | undefined;
let extraProjectIds: string[] = [];
const reissuing = !!existingMember;
const existingProjectIds = existingMember
? (existingMember.projects || []).map((p) => p.id)
: [];

if (existingMember) {
// Pure re-issue (existing member, no explicit --role): reuse their current
// role + projects. But an explicit --role MUST be honored so admins can
// promote/demote on re-invite — and so a re-invite that races a just-issued
// `kick` (a not-yet-propagated member read) still applies the requested
// role instead of silently keeping the stale one.
if (existingMember && !opts.role) {
role = existingMember.role;
const existingProjectIds = (existingMember.projects || []).map((p) => p.id);
projectId = existingProjectIds[0];
extraProjectIds = existingProjectIds.slice(1);
} else {
Expand Down Expand Up @@ -220,9 +227,13 @@ export class InviteCommand {
projectId = resolved[0];
extraProjectIds = resolved.slice(1);
} else if (!interactive) {
// No --project: fall back to the cwd project, else refuse — we
// won't silently grant access to a project the caller didn't name.
if (cwdProjectId) {
// No --project: keep the member's existing projects on re-issue, else
// fall back to the cwd project, else refuse — we won't silently grant
// access to a project the caller didn't name.
if (reissuing && existingProjectIds.length > 0) {
projectId = existingProjectIds[0];
extraProjectIds = existingProjectIds.slice(1);
} else if (cwdProjectId) {
projectId = cwdProjectId;
} else {
refuseNonInteractive(
Expand Down
Loading