Capture clone subprocess output to match rest of file - #18
Open
jamesgol wants to merge 1 commit into
Open
Conversation
Add capture_output=True to the git clone call in shallow_clone(), consistent with every other subprocess call in the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every other subprocess call in
clone.py(scrub, fetch, checkout) usescapture_output=True, but the maingit clonecall inshallow_clone()does not, its stderr goes straight to the parent process's file descriptors. This addscapture_output=Trueto match the rest of the file.