Add -- end-of-options separator to git fetch in harness clone - #16
Open
jamesgol wants to merge 1 commit into
Open
Add -- end-of-options separator to git fetch in harness clone#16jamesgol wants to merge 1 commit into
jamesgol wants to merge 1 commit into
Conversation
Prevents option-like values from being interpreted as git flags.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent-side
clone.pyalready uses--separators in its git subprocess calls to guard against values that could be misinterpreted as flags. The harness-sideclone_at_commit()passes the commit hash straight togit fetchwithout one. This brings the harness in line with the agent's existing defensive style.