Repository navigation
Translate the growth and integrations navigation groups - #730
Merged
Merged
Conversation
Companion packages place resources in the 'growth' (Socials, Social Feeds) and 'integrations' (Shopify Commerce) navigation groups, but Admin's language file had neither key, so the sidebar showed the raw key capell-admin::navigation.group_growth. A test now discovers every navigation group key and requires each to translate in every shipped locale without fallback.
howdu
enabled auto-merge (squash)
October 3, 2026 03:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion packages put resources in the
growthgroup (Socials, Social Feeds) and theintegrationsgroup (Shopify Commerce). Admin's language file had neither key, so the admin sidebar showed the raw keycapell-admin::navigation.group_growthas a group header. Package screenshots caught it.This adds both keys. A new
NavigationGroupTranslationsTestdiscovers every navigation group key in Foundation source, plus the companion-only keys, and requires each to translate in every shipped locale with fallback disabled. A sweep of Core and Packages found 14 keys, and all now translate. No Packages-side keys need changes.Verified: the guard failed before the fix on
group_growth, and after it the focused admin tests pass (21 tests).