Repository navigation
Plan after-install steps for action-only packages and fix navigation badge config - #725
Merged
Merged
Conversation
…badge config The install plan listed an after-install step only when a package declared a command, while the executors also accepted an action, so a package whose manifest names only an action (the extension cookbook) was dropped from the plan yet still ran. One helper now decides, and the plan and both executors use it. The Page and User navigation badge switches were nested under assets, but the resource trait reads capell-admin.resources.<name>.navigation_badge, so the defaults never applied and the badges showed whenever counts were on. They now sit under resources, and the unread page_redirects block is removed. CAP-0944 CAP-0948
howdu
enabled auto-merge (squash)
October 2, 2026 14:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
InstallPackagesAction,AfterInstallPackageAction) also accept an action. A package whose manifest names only an after-install action (the extension cookbook) was missing from the plan while still running, so progress and ordering disagreed with what executed.capell-admin.assets, butHasNavigationBadgereadscapell-admin.resources.<name>.navigation_badge. The defaults never applied and the badges showed whenever counts were enabled.Change
PackageLifecycleSteps::hasAfterInstall(), decides; the plan and both executors use it.resources; the unreadpage_redirectsblock is removed; the two live keys are documented indocs/development/configuration.mdand dropped from the internal classification list.Tests
InstallPlanTest: action-only case (failed before) and no-command-no-action case.HasNavigationBadgeTest(new): defaults hide both badges, explicittrueshows, counts off hides. Two of the four failed before the fix.check:docs-config,check:docs-env, Pint, Rector, PHPStan clean on changed files.CAP-0944 CAP-0948